Merged
Conversation
- Update dependency versions in `package.json` - Run `npm install --include=dev` - Run `npx gulp build build:min`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves various vulnerabilities for dependencies referenced in this package's
package-lock.jsonNPM lockfile. All of these dependencies are development-only (e.g. they are intended for use by developers of this package).Also bump
jqueryto 4.0.0 - this is a bit questionable, becausejqueryis not really a runtime dependency of this component yet -- it was originally intended to be, with the objective of making the source code more succinct.The vulnerabilities resolved are:
yargs-parser: Vulnerable to Prototype Pollutionminimatch:minimatchhas ReDoS: matchOne() combinatorial backtracking via multiple non-adjacent GLOBSTAR segmentsbraces: Uncontrolled resource consumption inbraceslodash: Command Injection inlodashcopy-props: Prototype Pollution incopy-propsdecode-uri-component:decode-uri-componentvulnerable to Denial of Service (DoS)minimist: Prototype pollution inminimistWe don't import/
requirethese modules directly, and their indirect usage via this repository'sgulpfile.jsappears minimal, appropriate and safe -- however, I cannot guarantee that developers using this codebase would not have been in-practice vulnerable at all to these reported vulnerabilities.Testing this locally caused me to observe that Firefox with canvas-fingerprint detection enabled introduces noise to the displayed/submitted screenshots -- I had noticed this before in production, but had not yet identified the cause. I'll report a privacy investigation issuethread for that soon.