Skip to content

Affine feature2D - Bug fix #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
opencv-pushbot merged 1 commit into from Nov 27, 2017
Merged

Affine feature2D - Bug fix #1463

opencv-pushbot merged 1 commit into from Nov 27, 2017

Conversation

@ghost
Copy link

@ghost ghost commented Nov 24, 2017

This pullrequest changes

Prevent crashing due to invalid co-variant matrix

@alalek
Copy link
Member

alalek commented Nov 24, 2017

Are there some simple reproducer for this crash?

What is about to add this on line 173:

if (Lxmysmooth.empty())
{
    //??? i++;
    continue;
}

@ghost
Copy link
Author

ghost commented Nov 24, 2017

@alalek You can reproduce it using the code provided in #933 (comment) and the following image:
affine_detector_test

alalek
alalek approved these changes Nov 27, 2017
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@opencv-pushbot opencv-pushbot merged commit 36291fa into opencv:master Nov 27, 2017
opencv-pushbot pushed a commit that referenced this pull request Nov 27, 2017
@alalek
Merge pull request #1463 from Sahloul:affine_feature2d
d47288d
@ghost ghost deleted the affine_feature2d branch January 12, 2018 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alalek alalek

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alalek @opencv-pushbot @cv3d