Skip to content

Conversation

@timeuser4
Copy link
Contributor

@timeuser4 timeuser4 commented Dec 10, 2025

OpenCV Extra: opencv/opencv_extra#1294

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@timeuser4 timeuser4 marked this pull request as draft December 10, 2025 07:09
@timeuser4 timeuser4 marked this pull request as ready for review December 10, 2025 07:09
@asmorkalov asmorkalov changed the title Feature/lanczos4 Add CUDA version to lanczos Add CUDA implementation for resize with lanczos interpolation Dec 10, 2025
@asmorkalov asmorkalov changed the title Add CUDA implementation for resize with lanczos interpolation Add CUDA implementation for resize with Lanczos interpolation Dec 10, 2025
@timeuser4
Copy link
Contributor Author

@asmorkalov
Could you tell me why I keep getting this error when building tests on Ubuntu 2004-x64-CUDA? I've tried fixing it several times but can't avoid it. The AI ​​tells me it's because the framework lacks test data and has nothing to do with the code. Is that true?

[----------] 54 tests from Sz_Depth_Cn_Inter_Scale_ResizeLanczos
[ RUN      ] Sz_Depth_Cn_Inter_Scale_ResizeLanczos.ResizeLanczos/0, where GetParam() = (1280x720, CV_8U, Gray, UNKNOWN, 0.5)
/home/ci/opencv/modules/ts/src/ts_perf.cpp:622: Failure
Failed
  No regression data for gpu_dst argument, test node: Sz_Depth_Cn_Inter_Scale_ResizeLanczos--ResizeLanczos---1280x720--CV_8U--Gray--UNKNOWN--0-5-

@asmorkalov
Copy link
Contributor

OpenCV performance tests hve sanity checks for the function results. The check includes min, max values and pixel values in several random points. CPU_SANITY_CHECK does it for you. The "gold" values are stored in opencv_extra repo in perf/<module_name>.xml. You need to run your new tests with --perf_write_sanity option to get xml with the new regression data, then append the block to existing xml file and submit a PR to opencv_extra repo. The PR should be submitted with the same author and the same branch name to be tested together on CI.

@timeuser4
Copy link
Contributor Author

OpenCV performance tests hve sanity checks for the function results. The check includes min, max values and pixel values in several random points. CPU_SANITY_CHECK does it for you. The "gold" values are stored in opencv_extra repo in perf/<module_name>.xml. You need to run your new tests with --perf_write_sanity option to get xml with the new regression data, then append the block to existing xml file and submit a PR to opencv_extra repo. The PR should be submitted with the same author and the same branch name to be tested together on CI.

Okay, thank you for your reply. I will add the missing parts.

@timeuser4
Copy link
Contributor Author

@asmorkalov
Everything is ready.🫡

@timeuser4
Copy link
Contributor Author

@asmorkalov Will this PR be merged?

@asmorkalov asmorkalov self-assigned this Dec 16, 2025
@asmorkalov asmorkalov merged commit fbdb8b2 into opencv:4.x Dec 16, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants