[re] fix: change to x,y,w,h format in NMSBoxes() #280
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souhhmm
changed the title
fengyuentau
reviewed
Dec 2, 2024
Member
fengyuentau
left a comment
fengyuentau
left a comment
There was a problem hiding this comment.
Thank you for your fix! We can make use of RotatedRect instead. You could have a look below for more details.
| bboxes[:, 0] = np.min(dets[:, [0, 2, 4, 6]], axis=1) # top-left x | ||
| bboxes[:, 1] = np.min(dets[:, [1, 3, 5, 7]], axis=1) # top-left y | ||
| bboxes[:, 2] = np.max(dets[:, [0, 2, 4, 6]], axis=1) - bboxes[:, 0] # width | ||
| bboxes[:, 3] = np.max(dets[:, [1, 3, 5, 7]], axis=1) - bboxes[:, 1] # height |
Member
There was a problem hiding this comment.
Actually NMSBoxes supports RotatedRect (See https://docs.opencv.org/4.x/d6/d0f/group__dnn.html#gaeec27cb32195e71e6d88032bda193162). So there is no need to de-rotate the boxes.
self._decode returns a set of four corners points but RotatedRect only needs three points for constructor (See https://docs.opencv.org/4.x/db/dd6/classcv_1_1RotatedRect.html). So try to remove one set of a corner point from dets and make it being initialized as RotatedRect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #275. Changed format to [x, y, width, height] as per NMSBoxes() and Rect_().