Skip to content

v2.1-rc

  • v2.1-rc
  • 5346d0b

  • Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode

  • Choose a tag to compare

    View all tags
v2.1-rc: Use patches to stop notebooks (#415)
  • v2.1-rc
  • 5346d0b

  • Choose a tag to compare

    View all tags

  • Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
@andrewballantyne andrewballantyne tagged this 25 Aug 18:32 
* Use Notebooks as a source of KFNBC State

- Removes dependency on OdhDashboardConfig
- Stores user last selection in Notebook
- Don't trust Notebook for running state -- make an API call for pod status
- Uses the stop annotation on the Notebook instead of deleting it
- Reworks heavily the NotebookControllerContext
- Fix it so if the notebook start modal hits an error it unsets it on the next
  progress
- Minor improvements to managing React components now that Notebook is state

* Cleaned up backend fetching for more use-cases

* Fix an optionality issue with KFNBC being enabled
Assets 2
Loading