Merged
Conversation
…r ods-adv-analysis, fix the CSS
… the fields and datasetid
…à la fin pour dire que le switch est optionnel - coté CSS, quasiment rien, juste ajouté un min-width pour le pyramid middle et un white-space: nowrap; - Sinon, on reste en flex, vu que ça ne semble pas choquer les valeurs qui pousse les bars... on vera à l'usage :homme_haussant_les_épaules::couleur_de_peau-3: - J'ai supprimé le ods-aggregation total - et surtout, j'ai remplacé les .sex par [genderfield] comme on s'était dit
Contributor
Author
|
Petit update avec le dataset de Issy mis sur userclub pour la version vega-lite. |
etienneburdet
approved these changes
Sep 15, 2021
Contributor
etienneburdet
left a comment
etienneburdet
left a comment
There was a problem hiding this comment.
Nickel, ça marche très bien 👌 J'ai essayé de faire avec un seul adv-analysis, mais c'est tordu, on est aussi bien avec deux.
|
|
||
| .pyramid-middle { | ||
| font-weight: 500; | ||
| flex: 1; |
Contributor
There was a problem hiding this comment.
J'ai tendance à utiliser flex-grow avec une seule valeur et utiliser le shorthand uniquement pour 3 valeur (mais c'est assez perso).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like we said yesterday, I added a link to the Vega-lite presentation written in the Heatmap resource. I also explained a bit how to use the resource and fill in the right parts in the code.
Let me know if it needs more details.