Skip to content

Give the OpenDcsDataTable class the ability to add cell borders.#135

Merged
wjonassen merged 2 commits intoopendcs:mainfrom
wjonassen:feature/properties_table_borders
Oct 4, 2024
Merged

Give the OpenDcsDataTable class the ability to add cell borders.#135
wjonassen merged 2 commits intoopendcs:mainfrom
wjonassen:feature/properties_table_borders

Conversation

@wjonassen
Copy link
Collaborator

Problem Description

Right now, data tables cannot have cell borders. We need to have the ability to add in cell borders.

Solution

Give the ability, from an OOP perspective, for datatables to have cell borders. This will be an optional object that will be passed into the OpenDcsDataTable constructor, where by default the cell borders will be set to true if this optional object is not passed in.

how you tested the change

Verified the cell borders exist if:

  1. The object is passed in with cellBorders = true.
  2. The object is not passed in.
    Verified the cell borders do not exist if:
  3. The object is passed in with cellBorders = false;

Where the following done:

  • Tests. Check all that apply:
    • Unit tests created or modified that run during ant test.
    • Integration tests created or modified that run during integration testing
      (Formerly called regression tests.)
    • Test procedure descriptions for manual testing
  • Was relevant documentation updated?
  • Were relevant config element (e.g. XML data) updated as appropriate

…, as well as the ability for other, future table properties.

By default, cell borders is true, unless value is passed in.
@wjonassen wjonassen requested a review from MikeNeilson April 2, 2024 15:48
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@wjonassen wjonassen merged commit 0475e2b into opendcs:main Oct 4, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 30%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants