Give the OpenDcsDataTable class the ability to add cell borders.#135
Merged
wjonassen merged 2 commits intoopendcs:mainfrom Oct 4, 2024
Merged
Conversation
…, as well as the ability for other, future table properties. By default, cell borders is true, unless value is passed in.
|
MikeNeilson
approved these changes
Apr 3, 2024
opendcs-web-client/src/main/webapp/resources/js/datatables/datatables.js
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Problem Description
Right now, data tables cannot have cell borders. We need to have the ability to add in cell borders.
Solution
Give the ability, from an OOP perspective, for datatables to have cell borders. This will be an optional object that will be passed into the OpenDcsDataTable constructor, where by default the cell borders will be set to true if this optional object is not passed in.
how you tested the change
Verified the cell borders exist if:
Verified the cell borders do not exist if:
Where the following done:
(Formerly called regression tests.)