Add CWMS Support for OpenDCS REST API#271
Merged
adamkorynta merged 92 commits intomainfrom Mar 24, 2025
Merged
Conversation
6 tasks
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
|
e8200fd to
3601bce
Compare
* updates to allow integration tests to run in GitHub Actions on feature/task_cwms_support branch * disable CWMS for now
* refactor algorithmresource to use DAO from toolkit * add integration tests for algorithm endpoints * add jacoco coverage for integration tests
…t implementations (#364) * Removed custom properties mapping, used Toolkit implementations * Added null check for empty properties object
3d0e5ad to
2a748de
Compare
|
Contributor
Author
|
Now that we have an official toolkit release and aren't building local dev jars, this PR is ready to merge into main. |
Contributor
Author
|
Outstanding things to do in follow-up PR's:
|
zack-rma
approved these changes
Mar 13, 2025
wjonassen
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem Description
Need staging branch for all CWMS implementation refactors
Solution
use feature/task_cwms_support for staging and then once complete merge into main.
how you tested the change
Integration tests will be merged into feature/task_cwms_support as they are written.
Where the following done:
(Formerly called regression tests.)