Skip to content

fix sonar usage so that it can be run from forked repositories#372

Merged
adamkorynta merged 1 commit intomainfrom
devops/fix_sonar_workflow_from_fork
Mar 24, 2025
Merged

fix sonar usage so that it can be run from forked repositories#372
adamkorynta merged 1 commit intomainfrom
devops/fix_sonar_workflow_from_fork

Conversation

@adamkorynta
Copy link
Contributor

Problem Description

Running sonar analysis from a forked repository with a user who does not have write permissions fails authentication to the SonarCloud service.

Solution

Add a github action hook that triggers as the GitHub account to run based on successful build+test execution so that the correct repo permissions are used.

how you tested the change

Will be testing by getting @zack-rma to PR into this change.

Where the following done:

  • Tests. Check all that apply:
    • Unit tests created or modified that run during ant test.
    • Integration tests created or modified that run during integration testing
      (Formerly called regression tests.)
    • Test procedure descriptions for manual testing
  • Was relevant documentation updated?
  • Were relevant config element (e.g. XML data) updated as appropriate

@adamkorynta
Copy link
Contributor Author

huh, looks like I need to get the sonar.yml into main first. I'll wait until feature/task_cwms_support merges first

@MikeNeilson
Copy link
Collaborator

huh, looks like I need to get the sonar.yml into main first. I'll wait until feature/task_cwms_support merges first

Yep, but it looks like it's setup correctly at least.

@adamkorynta adamkorynta marked this pull request as ready for review March 24, 2025 15:35
@adamkorynta adamkorynta changed the base branch from feature/task_cwms_support to main March 24, 2025 15:35
@adamkorynta adamkorynta force-pushed the devops/fix_sonar_workflow_from_fork branch from 5a6f1ae to 25f0ac6 Compare March 24, 2025 15:55
@adamkorynta adamkorynta merged commit f40f1d6 into main Mar 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants