fix sonar usage so that it can be run from forked repositories#372
Merged
adamkorynta merged 1 commit intomainfrom Mar 24, 2025
Merged
fix sonar usage so that it can be run from forked repositories#372adamkorynta merged 1 commit intomainfrom
adamkorynta merged 1 commit intomainfrom
Conversation
MikeNeilson
reviewed
Mar 14, 2025
Contributor
Author
|
huh, looks like I need to get the sonar.yml into main first. I'll wait until feature/task_cwms_support merges first |
Collaborator
Yep, but it looks like it's setup correctly at least. |
5a6f1ae to
25f0ac6
Compare
MikeNeilson
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
Running sonar analysis from a forked repository with a user who does not have write permissions fails authentication to the SonarCloud service.
Solution
Add a github action hook that triggers as the GitHub account to run based on successful build+test execution so that the correct repo permissions are used.
how you tested the change
Will be testing by getting @zack-rma to PR into this change.
Where the following done:
(Formerly called regression tests.)