fix(packaging): include py.typed and .pyi stubs in wheel#77
Merged
Conversation
Without [tool.setuptools.package-data], setuptools omits non-Python files from the built wheel. This means py.typed and the generated .pyi stubs were never shipped, silently breaking the "Typing :: Typed" classifier. Add the package-data declaration, a CI wheel-check job that builds the wheel and asserts py.typed is present, and a README Typing section that documents the guarantee. Closes #47 Co-Authored-By: Claude <noreply@anthropic.com>
zeevdr
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
py.typedand the generated.pyistubs because[tool.setuptools.package-data]was not declared — silently breaking theTyping :: Typedclassifier shipped in the metadata.wheel-checkjob that builds the wheel and assertspy.typedis present, preventing regression.Test plan
wheel-checkjob passes — wheel containspy.typedTyping :: Typedclassifier is now accurately reflected in the distributed wheelCloses #47
🤖 Generated with Claude Code