fix(async-watcher): forward auth metadata to GetConfig and Subscribe#78
Merged
Conversation
AsyncConfigClient cannot use channel interceptors, so it injects auth metadata per-call via self._metadata(). AsyncConfigWatcher was not receiving this metadata, causing both the initial GetConfig snapshot and the Subscribe streaming call to omit auth headers. Auth-enabled servers rejected the Subscribe with UNAUTHENTICATED. Added a metadata parameter to AsyncConfigWatcher.__init__ and thread it through both _load_snapshot and _subscribe_loop. Updated AsyncConfigClient.watch() to pass self._metadata(). Added a unit test asserting that both gRPC calls receive the correct metadata tuples. Co-Authored-By: Claude <noreply@anthropic.com> Closes #48
zeevdr
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AsyncConfigWatcherbypassed the per-call auth metadata injection thatAsyncConfigClientuses for all unary calls, causing auth-enabled servers to reject theSubscribestream (and the initialGetConfigsnapshot) withUNAUTHENTICATED.metadataparameter toAsyncConfigWatcher.__init__and threaded it through both_load_snapshotand_subscribe_loop.AsyncConfigClient.watch()to passself._metadata()when constructing the watcher.Test plan
test_auth_metadata_forwarded— asserts that bothGetConfigandSubscribereceive the correct metadata tuples when the watcher is constructed with auth metadata.make test, 97.69% coverage).Closes #48
🤖 Generated with Claude Code