fix(schema)!: rename top-level syntax → spec_version (#118)#130
Merged
Conversation
Clearer intent — $schema (landing in #119) will carry the "which meta-schema validates this" pointer, leaving spec_version to express the logical format version. Applied symmetrically to the config YAML format (same top-level shape). Breaking change. Per the no-backward-compat policy for pre-production, no deprecation helper and no migration alias — YAMLs with the old key fail at parse time with "spec_version is required". Design brief: .agents/context/schema-spec.md, milestone Schema Spec v0.1.0. - internal/schema/yaml.go, internal/config/yaml.go: const + struct tag renamed, error messages updated - sdk/tools/{validate,seed,dump}: parser + marshaler updated - examples/**, fixtures/**, docs/**: fixtures + user-facing samples migrated to spec_version - proto doc comments updated; api/*.pb.go regenerated Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
make docs regen — proto comment changes in the prior commit needed propagation to docs/api/api-reference.md. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zeevdr
added a commit
that referenced
this pull request
Apr 21, 2026
* fix(schema)!: rename top-level syntax → spec_version (#118) Clearer intent — $schema (landing in #119) will carry the "which meta-schema validates this" pointer, leaving spec_version to express the logical format version. Applied symmetrically to the config YAML format (same top-level shape). Breaking change. Per the no-backward-compat policy for pre-production, no deprecation helper and no migration alias — YAMLs with the old key fail at parse time with "spec_version is required". Design brief: .agents/context/schema-spec.md, milestone Schema Spec v0.1.0. - internal/schema/yaml.go, internal/config/yaml.go: const + struct tag renamed, error messages updated - sdk/tools/{validate,seed,dump}: parser + marshaler updated - examples/**, fixtures/**, docs/**: fixtures + user-facing samples migrated to spec_version - proto doc comments updated; api/*.pb.go regenerated Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(api): regenerate api-reference.md for spec_version rename make docs regen — proto comment changes in the prior commit needed propagation to docs/api/api-reference.md. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: zeevdr <zeev.dreifuss@ownera.io> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zeevdr
added a commit
that referenced
this pull request
Apr 21, 2026
* fix(schema)!: rename top-level syntax → spec_version (#118) Clearer intent — $schema (landing in #119) will carry the "which meta-schema validates this" pointer, leaving spec_version to express the logical format version. Applied symmetrically to the config YAML format (same top-level shape). Breaking change. Per the no-backward-compat policy for pre-production, no deprecation helper and no migration alias — YAMLs with the old key fail at parse time with "spec_version is required". Design brief: .agents/context/schema-spec.md, milestone Schema Spec v0.1.0. - internal/schema/yaml.go, internal/config/yaml.go: const + struct tag renamed, error messages updated - sdk/tools/{validate,seed,dump}: parser + marshaler updated - examples/**, fixtures/**, docs/**: fixtures + user-facing samples migrated to spec_version - proto doc comments updated; api/*.pb.go regenerated Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(api): regenerate api-reference.md for spec_version rename make docs regen — proto comment changes in the prior commit needed propagation to docs/api/api-reference.md. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: zeevdr <zeevdr@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #118. Part of milestone Schema Spec v0.1.0. Design brief:
.agents/context/schema-spec.md(landing in #128).Summary
syntax:→spec_version:in both schema YAML and config YAML formats.internal/schema,internal/config), SDK tools (sdk/tools/{validate,seed,dump}), fixtures, examples, docs, and proto doc comments.spec_version(e.g.spec_version is required,unsupported spec_version).Scope
schemas/schema-yaml.json(preliminary meta-schema) updated for consistency; full rewrite comes with Author meta-schema v0.1.0 (JSON Schema 2020-12) #123.Test plan
make test— all packages greenmake lint— 0 issuesmake e2e— all tests pass after rebuilding the service imagemake generate— proto doc comments → regenerated.pb.go+docs/api/*.json🤖 Generated with Claude Code