bench(storage,cache,pubsub): add hot-path benchmarks#503
Merged
Conversation
Add benchmark suites for the three hot paths identified in #473: - internal/cache: MemoryCache hit/miss/eviction; RedisCache get/set/invalidate (skipped when REDIS_URL is unset) - internal/pubsub: MemoryPubSub publish with 0/1/10/50 subscribers; RedisPubSub publish and fan-out (skipped when REDIS_URL is unset) - internal/storage/dbstore: SetConfigValue, GetFullConfigAtVersion, ListTenants against a real Postgres pool (skipped when DB_WRITE_URL is unset); fixture sets up schema→version→tenant→config_version and cleans up on b.Cleanup CI bench job extended to include the new packages, run with -count=5 for benchstat percentile output, and pipe results through benchstat to surface p50/p95 in the uploaded artifact. Closes #473 Co-Authored-By: Claude <noreply@anthropic.com>
zeevdr
added
enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BenchmarkMemoryCache_Hit/Miss/SetEvictsOldestandBenchmarkRedisCache_Get/Set/Invalidate(Redis skipped whenREDIS_URLunset).BenchmarkMemoryPubSub_Publish/FanOut(0–50 subscribers) andBenchmarkRedisPubSub_Publish/FanOut(Redis skipped whenREDIS_URLunset).BenchmarkSetConfigValue,BenchmarkGetFullConfigAtVersion, andBenchmarkListTenantsagainst a real Postgres pool, with full schema→tenant→config_version fixture setup and cleanup (skipped whenDB_WRITE_URLunset).-count=5for benchstat, and uploads both raw results and percentile summary as artifacts.Test plan
go test -bench=^BenchmarkMemoryCache -benchmem -benchtime=500ms ./internal/cache/— three benchmarks run and complete cleanly.go test -bench=^BenchmarkMemoryPubSub -benchmem -benchtime=500ms ./internal/pubsub/— publish and fan-out (1/10/50 subs) benchmarks run cleanly.go test -bench=. -benchmem -run='^$' -benchtime=500ms ./internal/storage/dbstore/— skips cleanly whenDB_WRITE_URLis unset.REDIS_URLis unset.bench.txtandbench-stats.txtartifacts.Closes #473
🤖 Generated with Claude Code