Get rid of Artifactory dependency#466
Conversation
| [submodule "OpenDocument.core"] | ||
| path = OpenDocument.core | ||
| url = https://github.com/opendocument-app/OpenDocument.core |
There was a problem hiding this comment.
I think this should rather depend on https://github.com/opendocument-app/conan-odr-index so versions make sense. updates can be automated with renovate
There was a problem hiding this comment.
makes sense, but by the time you mentioned this idea earlier today I had it all implemented already. also, I hope I can leverage that core submodule in other ways in the future, i.e. reusing latest test documents in an automated fashion... or maybe I'm dreaming!
There was a problem hiding this comment.
right but that can also be achieved by getting the test repo as submoulde
depending directly on the core means that the directory structure couples which adds another thing that can break
we would still need to bump the submodule to core to make an update but lose the version number. does not really seem worth to me. but your call on the platform side
|
Fixes #449 |
2 participants
opendocument-app/OpenDocument.core#472