Improved launch screen.#39
Conversation
|
TODO for me: provide higher resolution app icon |
TomTasche
left a comment
TomTasche
left a comment
There was a problem hiding this comment.
Test plan:
- launch app on device in portrait mode, check if launch screen is shown
- kill app, change to landscape mode
- launch app, check if launch screen is shown
Test results:
- black screen shown on iPhone 8 in landscape mode
- no icon shown on iPad Air
| }, | ||
| { | ||
| "idiom" : "iphone", | ||
| "filename" : "launch_image.png", |
There was a problem hiding this comment.
could you reuse the appicon assets directly? https://github.com/TomTasche/OpenDocument.ios/blob/5116af24442bcf61cea383b5bfd02aa7f836bbf2/OpenDocumentReader/Assets.xcassets/AppIcon.appiconset/1024.png
There was a problem hiding this comment.
i guess i can, but i am not sure, that is a best practise to use the same image(size) for all devices.
|
|
|
"no icon on iPad air." |
|
Regarding iPhone 8: nice, that only seems to happen if you tilt the device to the left (you tilted to the right). Moreover, the launch screen is upside down if you tilt the phone upside down (not important to fix right now, just an observation). Regarding icons: please use the one I linked to earlier. Doesn't matter if you duplicate it or reference the original. That's the highest resolution we have right now. Is that enough? @Metaxa007 |
|
@TomTasche |
|
Weird, now it doesn't work the other way around. Minor bug, we can ignore that for now! |
2 participants
No description provided.