Build + status#40
Build + status#40TomTasche merged 35 commits intoopendocument-app:developmentfrom marcelblanarik:master
Conversation
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - name: Checkout submodule | ||
| run: git submodule sync --recursive && git submodule update --init --recursive |
There was a problem hiding this comment.
as far as i know "git submodule sync --recursive" is not necessary? "git submodule update --init --recursive" initializes and updates them anyway
There was a problem hiding this comment.
you're right, I removed the sync part
| runs-on: macos-latest | ||
| strategy: | ||
| matrix: | ||
| destination: ['platform=iOS Simulator,OS=13.1,name=iPhone 11'] |
There was a problem hiding this comment.
does github actions guarantee all the OS versions being installed all the time? or do we have to update this field every time a new version is released? is there a way to use the latest one automatically?
There was a problem hiding this comment.
unfortunately, I didn't find any way how to use OS=latest, or something like that, there is an option to not use OS at all, but one still has to specify the phone name, which doesn't solve this issue anyway
| run: pod install | ||
| - name: Run build.sh | ||
| run: bash build.sh | ||
| - name: Build and test |
There was a problem hiding this comment.
i'm nitpicking, but this is just "Build", not "test"
There was a problem hiding this comment.
test was removed
| @@ -1,4 +1,4 @@ | |||
| # OpenDocument.ios | |||
| # OpenDocument.ios  | |||
There was a problem hiding this comment.
please change link to original repository so it immediately works after merge
|
By the way, does this build each and every commit now? Or only pull requests? Is the build status shown for each commit / pull request on GitHub? |
|
Did you close this on purpose? |
|
Hmm, not on purpose, maybe accidentally, sorry, was going to reply you and
might click where is wasn't supposed to :D could you please reopen it? I'm
not very familiar with Github yet..
…On Mon, Dec 23, 2019 at 7:06 AM Thomas Taschauer ***@***.***> wrote:
Did you close this on purpose?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#40>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGE6TEZ7ZQCBBXM3RBOG6Y3Q2BIPBANCNFSM4J6HDHCQ>
.
--
S pozdravom
Marcel Blanárik
|
|
Added you as a collaborator, please merge and verify |
2 participants
add github action pipeline + add build status to Readme