Skip to content

Add Lite version with Ads.#52

Merged
TomTasche merged 10 commits intodevelopmentfrom
feature/lite-version
Apr 29, 2020
Merged

Add Lite version with Ads.#52
TomTasche merged 10 commits intodevelopmentfrom
feature/lite-version

Conversation

@Metaxa007
Copy link
Copy Markdown
Contributor

No description provided.

@Metaxa007 Metaxa007 requested a review from TomTasche April 13, 2020 17:24
Copy link
Copy Markdown
Member

@TomTasche TomTasche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally works, thank you! the Full and Lite targets use debug configuration, which means I won't be able to release it like that (e.g. see "Optimization Level" in screenshot attached).

other than that, the ads don't really fill the screen from left to right. on Android they have special ads that try to fill the screen as much as possible. does that exist on iOS too? also, do we control the background color? currently it shows black bars left and right...

Screenshot 2020-04-14 at 20 15 20

struct ConfigurationManager {
static let manager = ConfigurationManager()

private(set) var configuration: String!
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's private(set)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only setter is private. getter is public

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we can not control the background color. There is a property adSize, but the documentation says, we should not create own sizes, but use predefined that can not cover the whole width. Probably i need to investigate more how to fix this problem.

@TomTasche
Copy link
Copy Markdown
Member

are we using adaptive banners? those should fill the screen as much as possible https://developers.google.com/admob/ios/banner/adaptive

Copy link
Copy Markdown
Member

@TomTasche TomTasche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can still see a few options that are not set properly for Lite / Full. Maybe it makes sense to create them from scratch and copy over from Release? Also, can you point me to the guide you were using to do that?

AC384BCD23B4FFA700C7BF47 /* ContentViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = AC384BC923B4FFA700C7BF47 /* ContentViewController.swift */; };
AC384BCE23B4FFA700C7BF47 /* Constants.swift in Sources */ = {isa = PBXBuildFile; fileRef = AC384BCA23B4FFA700C7BF47 /* Constants.swift */; };
AC384BCF23B4FFA700C7BF47 /* PageViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = AC384BCB23B4FFA700C7BF47 /* PageViewController.swift */; };
AC6A1CD9243E6B8400CD42EC /* (null) in Sources */ = {isa = PBXBuildFile; };
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's that? 🤷

Copy link
Copy Markdown
Contributor Author

@Metaxa007 Metaxa007 Apr 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird, i recreated both configurations from scratch. here ist the guide that i used:

@TomTasche
Copy link
Copy Markdown
Member

this seems like a good approach: https://blog.testfairy.com/2-ios-apps-1-codebase-with-xcode-scheme/

problem with yours right now: even while developing you are building the app in release mode, which means longer build times and worse debugging support! @Metaxa007

@Metaxa007
Copy link
Copy Markdown
Contributor Author

@TomTasche thanks, nice tutorial. I implemented changes according to it.

@TomTasche
Copy link
Copy Markdown
Member

Looks very good now! I'll do some more tests with uploading to the App Store to make sure it's working.

Would it be possible to hide / show the ad-area based on if an ad was loaded? Two scenarios I can think of:

  1. User starts the app and opens a document: white area is shown at the top until ad is loaded
  2. If the user doesn't have internet connectivity or no ad was loaded for another reason, the user will continue to see a white area

@TomTasche
Copy link
Copy Markdown
Member

Making a few commits to this branch to resolve merge conflicts. Please pull before making any further changes

@Metaxa007
Copy link
Copy Markdown
Contributor Author

I'll take a look. If it has a completion handler, would be very easy to implement what you described.

@Metaxa007
Copy link
Copy Markdown
Contributor Author

  1. "User starts the app and opens a document: white area is shown at the top until ad is loaded" to avoid it i have to set the view height to 0 and hide the view for the beginning, but in this case delegate immediately throws didFailToReceiveAdWithError and the Ad can not be loaded and shown.
  2. "If the user doesn't have internet connectivity or no ad was loaded for another reason, the user will continue to see a white area". That is where didFailToReceiveAdWithError is called and the view can be hidden.

@TomTasche TomTasche merged commit a091598 into development Apr 29, 2020
@TomTasche TomTasche deleted the feature/lite-version branch April 29, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants