Skip to content

fix(filter): add block-device-tag filter during manual claiming#404

Merged
kmova merged 2 commits intoopenebs-archive:masterfrom
akhilerm:fix-bd-tag
Sep 8, 2020
Merged

fix(filter): add block-device-tag filter during manual claiming#404
kmova merged 2 commits intoopenebs-archive:masterfrom
akhilerm:fix-bd-tag

Conversation

@akhilerm
Copy link
Copy Markdown
Contributor

@akhilerm akhilerm commented Apr 17, 2020

Signed-off-by: Akhil Mohan akhil.mohan@mayadata.io

@akhilerm akhilerm added the pr/hold-review Needs rework. label Apr 17, 2020
@akhilerm akhilerm modified the milestones: 0.4, 0.5 Apr 17, 2020
@akhilerm
Copy link
Copy Markdown
Contributor Author

akhilerm commented Apr 21, 2020

block-device-tag will not be checked if the BlockDevice is claimed manually.

@akhilerm akhilerm closed this Apr 21, 2020
@kmova
Copy link
Copy Markdown
Contributor

kmova commented Jun 4, 2020

Re-opening as it came up with #430

@kmova kmova reopened this Jun 4, 2020
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 17, 2020 •
edited
Loading

Codecov Report

Merging #404 into master will decrease coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #404      +/-   ##
==========================================
- Coverage   40.53%   40.37%   -0.16%     
==========================================
  Files          71       72       +1     
  Lines        3488     3529      +41     
==========================================
+ Hits         1414     1425      +11     
- Misses       1966     1995      +29     
- Partials      108      109       +1
Impacted Files Coverage Δ
pkg/select/blockdevice/select.go 0.00% <0.00%> (ø)
cmd/ndm_daemonset/controller/blockdevice.go 85.00% <0.00%> (-2.18%) ⬇️
cmd/ndm_daemonset/probe/probe.go 100.00% <0.00%> (ø)
cmd/ndm_daemonset/controller/ndmconfig.go 75.00% <0.00%> (ø)
...m_daemonset/controller/disk_to_device_convertor.go 0.00% <0.00%> (ø)
cmd/ndm_daemonset/probe/customtagprobe.go 30.55% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f514dfc...a624010. Read the comment docs.

@akhilerm
fix(filter): add block-device-tag filter during manual claiming
76e248f 
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm removed the pr/hold-review Needs rework. label Aug 17, 2020
@akhilerm akhilerm requested a review from kmova August 17, 2020 18:37
kmova
kmova previously approved these changes Aug 27, 2020
View reviewed changes
@kmova
Copy link
Copy Markdown
Contributor

kmova commented Aug 27, 2020

@akhilerm -- can you update with change log please.

@akhilerm
add changelog
a624010 
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm
Copy link
Copy Markdown
Contributor Author

akhilerm commented Aug 27, 2020

Done @kmova

@akhilerm akhilerm requested a review from kmova August 31, 2020 10:12
@kmova kmova added the pr/hold-merge The PR should not be merged now label Sep 3, 2020
@kmova
Copy link
Copy Markdown
Contributor

kmova commented Sep 3, 2020

The changes in this PR look good. This change will help with avoiding cases where BD reserved to be used by Local PV is not claimed by SPC. However, merging this might break some high-level automation scripts around cStor pool creation.

cStor Pool creation (SPC and CSPC) is adding a new feature to take as input "allowed-block-device-tags", so the BDs should be configed to the white-listed BD tags for a given SPC or CSPC.

This PR will be merge once the above changes are implemented. ( cc: @sonasingh46 )

@akhilerm akhilerm removed the pr/hold-merge The PR should not be merged now label Sep 8, 2020
@akhilerm
Copy link
Copy Markdown
Contributor Author

akhilerm commented Sep 8, 2020

The changes required are merged in the PR 172, 69 and 1748

@kmova kmova merged commit 503ec7f into openebs-archive:master Sep 8, 2020
akhilerm added a commit to akhilerm/node-disk-manager that referenced this pull request Sep 8, 2020
@akhilerm
fix(filter): add block-device-tag filter during manual claiming (op…
a5903fa 
…enebs-archive#404)

Enforce check on block device tag even for cases where block 
devices are claimed with block device name. 

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm mentioned this pull request Sep 8, 2020
Merged
kmova pushed a commit that referenced this pull request Sep 9, 2020
@akhilerm
fix(filter): add block-device-tag filter during manual claiming (#404)
4af5d55 
Enforce check on block device tag even for cases where block 
devices are claimed with block device name. 

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm mentioned this pull request Sep 10, 2020
Merged
@akhilerm akhilerm deleted the fix-bd-tag branch December 13, 2021 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kmova kmova kmova approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.5

Development

Successfully merging this pull request may close these issues.

5 participants

@akhilerm @kmova @codecov-commenter @sonasingh46 @Abhinandan-Purkait