fix(eventhandler): continue processing indepedent blockdevices even if one device fails#517
Merged
kmova merged 6 commits intoopenebs-archive:masterfrom Dec 8, 2020
Merged
Conversation
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
|
This pull request introduces 1 alert when merging f5f9b8f into 3bebe70 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #517 +/- ##
==========================================
+ Coverage 47.51% 47.69% +0.18%
==========================================
Files 73 73
Lines 3315 3336 +21
==========================================
+ Hits 1575 1591 +16
- Misses 1580 1584 +4
- Partials 160 161 +1
Continue to review full report at Codecov.
|
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
kmova
reviewed
Dec 7, 2020
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
kmova
approved these changes
Dec 8, 2020
akhilerm
added a commit
to akhilerm/node-disk-manager
that referenced
this pull request
Dec 9, 2020
…f one device fails (openebs-archive#517) * skip devices that don't have full attributes * keep track of the skipped device * add check for dependent devices of the skipped device and ignore them. Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
kmova
pushed a commit
that referenced
this pull request
Dec 10, 2020
…f one device fails (#517) * skip devices that don't have full attributes * keep track of the skipped device * add check for dependent devices of the skipped device and ignore them. Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this PR required? What issue does it fix?:
When one of the disk is bad in the node / NDM is not able to create blockdevice resource for the disk, NDM repeatedly performs the rescan operation, skipping the other disks. This results in some disks not being processed. This PR brings in a change to wait till all the disks are processed, before starting the rescan.
What this PR does?:
NOTE: This commit does not change the continuous rescan that NDM will do incase of a disk erroring out.
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Solves one issue mentioned in openebs/openebs#3051
Checklist:
<type>(<scope>): <subject>