Skip to content

fix(eventhandler): continue processing indepedent blockdevices even if one device fails#517

Merged
kmova merged 6 commits intoopenebs-archive:masterfrom
akhilerm:fix-bad-disk-bug
Dec 8, 2020
Merged

fix(eventhandler): continue processing indepedent blockdevices even if one device fails#517
kmova merged 6 commits intoopenebs-archive:masterfrom
akhilerm:fix-bad-disk-bug

Conversation

@akhilerm
Copy link
Copy Markdown
Contributor

@akhilerm akhilerm commented Dec 4, 2020

Why is this PR required? What issue does it fix?:
When one of the disk is bad in the node / NDM is not able to create blockdevice resource for the disk, NDM repeatedly performs the rescan operation, skipping the other disks. This results in some disks not being processed. This PR brings in a change to wait till all the disks are processed, before starting the rescan.

What this PR does?:

  • adds a check to skip processing of blockdevices if the parent or any of the slave devices of the given block device has errored out.

NOTE: This commit does not change the continuous rescan that NDM will do incase of a disk erroring out.

Does this PR require any upgrade changes?:

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Solves one issue mentioned in openebs/openebs#3051

Checklist:

  • Fixes
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm added the pr/hold-review Needs rework. label Dec 4, 2020
@lgtm-com
Copy link
Copy Markdown

lgtm-com Bot commented Dec 4, 2020

This pull request introduces 1 alert when merging f5f9b8f into 3bebe70 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 4, 2020

Codecov Report

Merging #517 (e5ab764) into master (3bebe70) will increase coverage by 0.18%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
+ Coverage   47.51%   47.69%   +0.18%     
==========================================
  Files          73       73              
  Lines        3315     3336      +21     
==========================================
+ Hits         1575     1591      +16     
- Misses       1580     1584       +4     
- Partials      160      161       +1     
Impacted Files Coverage Δ
cmd/ndm_daemonset/probe/eventhandler.go 48.14% <60.00%> (+3.70%) ⬆️
pkg/udev/common.go 87.30% <0.00%> (-2.70%) ⬇️
cmd/ndm_daemonset/probe/udevprobe.go 54.74% <0.00%> (+0.25%) ⬆️
cmd/ndm_daemonset/filter/pathfilter.go 76.92% <0.00%> (+5.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bebe70...e5ab764. Read the comment docs.

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm added pr/hold-merge The PR should not be merged now and removed pr/hold-review Needs rework. labels Dec 7, 2020
@akhilerm akhilerm requested a review from kmova December 7, 2020 05:59
Comment thread cmd/ndm_daemonset/probe/eventhandler.go
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm removed the pr/hold-merge The PR should not be merged now label Dec 8, 2020
@akhilerm akhilerm requested a review from kmova December 8, 2020 08:36
@kmova kmova merged commit fdcc9fb into openebs-archive:master Dec 8, 2020
akhilerm added a commit to akhilerm/node-disk-manager that referenced this pull request Dec 9, 2020
…f one device fails (openebs-archive#517)

* skip devices that don't have full attributes
* keep track of the skipped device 
* add check for dependent devices of the skipped device and ignore them. 

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
kmova pushed a commit that referenced this pull request Dec 10, 2020
…f one device fails (#517)

* skip devices that don't have full attributes
* keep track of the skipped device 
* add check for dependent devices of the skipped device and ignore them. 

Signed-off-by: Akhil Mohan <akhil.mohan@mayadata.io>
@akhilerm akhilerm deleted the fix-bad-disk-bug branch December 13, 2021 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants