This repository was archived by the owner on Aug 1, 2024. It is now read-only.
fix: remove DJANGO_SETTINGS_MODULE env from lms, cms#1045
Merged
iamsobanjaved merged 1 commit intomasterfrom Apr 4, 2023
Merged
fix: remove DJANGO_SETTINGS_MODULE env from lms, cms#1045iamsobanjaved merged 1 commit intomasterfrom
iamsobanjaved merged 1 commit intomasterfrom
Conversation
we are using `EDX_PLATFORM_SETTINGS` env variable for picking settings file to use with Django management commands. When this env variable is set to `lms.envs.devstack_docker`, with dev image being used with devstack, it picks that settings for running tests too as it has higher precedence than the settings in ini file. So removing this, so the test settings can be picked from ini file.
UsamaSadiq
approved these changes
Apr 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we are using
EDX_PLATFORM_SETTINGSenv variable for picking settings file to use with Django management commands. When this env variable is set tolms.envs.devstack_docker, with dev image being used with devstack, it picks that settings for running tests too as it has higher precedence than the settings in ini file. So removing this, so the test settings can be picked from ini file.I've completed each of the following or determined they are not applicable: