This repository was archived by the owner on Aug 1, 2024. It is now read-only.
fix: Only create users in mysql 8.0 if they don't already exist#1112
Merged
fix: Only create users in mysql 8.0 if they don't already exist#1112
Conversation
This issue was breaking provisioning early in the process. The images for mysql57 and mysql80 start off with users already present for some reason. The old provisioning script for mysql 5.7 (provision.sql) uses implicit user creation via the `GRANT` statement, which is no longer supported in mysql 8.0. Therefore, the `CREATE USER` statements in provision-mysql80.sql fail. The fix here is to change to `CREATE USER IF NOT EXISTS`. I've also deleted `drop-mysql-user.sql`. I suspect it was only used during testing to enable repeated tests of provisioning, but it's not referenced anywhere in the PR that adds it (#1097).
1 task
robrap
approved these changes
Jun 28, 2023
1 task
nsprenkle
pushed a commit
that referenced
this pull request
Nov 21, 2023
This issue was breaking provisioning early in the process. The volumes for mysql57 and mysql80 may still contain users from previous provisioning runs. The old provisioning script for mysql 5.7 (provision.sql) uses implicit user creation via the `GRANT` statement, which is no longer supported in mysql 8.0. Therefore, the `CREATE USER` statements in provision-mysql80.sql fail. The fix here is to change to `CREATE USER IF NOT EXISTS`. I've also deleted `drop-mysql-user.sql`. I suspect it was only used during testing to enable repeated tests of provisioning, but it's not referenced anywhere in the PR that adds it (#1097).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was breaking provisioning early in the process.
The volumes for mysql57 and mysql80 may still contain users from previous provisioning runs. The old provisioning script for mysql 5.7 (provision.sql) uses implicit user creation via the
GRANTstatement, which is no longer supported in mysql 8.0. Therefore, theCREATE USERstatements in provision-mysql80.sql fail. The fix here is to change toCREATE USER IF NOT EXISTS.I've also deleted
drop-mysql-user.sql. I suspect it was only used during testing to enable repeated tests of provisioning, but it's not referenced anywhere in the PR that adds it (#1097).I've completed each of the following or determined they are not applicable: