This repository was archived by the owner on Aug 1, 2024. It is now read-only.
feat: add analytics data api#847
Merged
zacharis278 merged 8 commits intomasterfrom Oct 25, 2021
Merged
Conversation
This was referenced Oct 21, 2021
zacharis278
force-pushed
the
zhancock/analytics-api
branch
from
db79294 to
edd9a5d
Compare
ashultz0
reviewed
Oct 21, 2021
| # ports: | ||
| # - "3506:3306" | ||
| ports: | ||
| - "3506:3306" |
Contributor
There was a problem hiding this comment.
I'm not docker syntax knowledgable but this change sticks out as unexpected, adding the analytics API means we have to change the mysql everyone uses?
Contributor
Author
There was a problem hiding this comment.
definitely unintended. Not the first time I've almost merged this local change 🙄
Contributor
Author
There was a problem hiding this comment.
I'm going to advocate for removing this comment altogether but I'll save that for it's own PR.
zacharis278
force-pushed
the
zhancock/analytics-api
branch
2 times, most recently
from
8121017 to
c034dff
Compare
zacharis278
force-pushed
the
zhancock/analytics-api
branch
from
c034dff to
17601e3
Compare
kdmccormick
reviewed
Oct 25, 2021
Co-authored-by: Kyle McCormick <kmccormick@edx.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@edx/masters-devs-cosmonauts
One notable change here is I have updated the mysql users for analytics to be more inline with the other devstack services.
Depends on: https://github.com/edx/edx-analytics-data-api/pull/495