This repository was archived by the owner on Aug 1, 2024. It is now read-only.
feat: forward mongo and mysql ports by default#848
Merged
zacharis278 merged 1 commit intomasterfrom Oct 27, 2021
Merged
Conversation
robrap
approved these changes
Oct 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems to me there's no reason to keep these commented out anymore.
Port forwarding for these services was originally removed due to port clashes when running vagrant devstack. Since that is no longer relevant we should add these back.
context from when this is added in 2016: edx/devstack#20