Skip to content
This repository was archived by the owner on Aug 1, 2024. It is now read-only.

feat: add kafka containers to devstack#854

Merged
rgraber merged 2 commits intomasterfrom
rsgraber/ARHCBOM-1943-setup-kafka-in-devstack
Nov 10, 2021
Merged

feat: add kafka containers to devstack#854
rgraber merged 2 commits intomasterfrom
rsgraber/ARHCBOM-1943-setup-kafka-in-devstack

Conversation

@rgraber
Copy link
Copy Markdown
Contributor

@rgraber rgraber commented Nov 8, 2021

Add kafka services to devstack. These include:


I've completed each of the following or determined they are not applicable:

  • Made a plan to communicate any major developer interface changes (or N/A)

@rgraber rgraber marked this pull request as ready for review November 8, 2021 16:57
@regisb
Copy link
Copy Markdown
Contributor

regisb commented Nov 9, 2021

Why is Kafka necessary in the devstack?

@rgraber
Copy link
Copy Markdown
Contributor Author

rgraber commented Nov 10, 2021

Why is Kafka necessary in the devstack?

We are in the process of developing an event bus for the platform, and for now kafka is our broker of choice. Adding it to devstack will be a big aid for local development.

Copy link
Copy Markdown
Contributor

@dianakhuang dianakhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my machine, but I would recommend making sure a Linux dev also gives it a shot.

Comment thread docker-compose.yml Outdated
aliases:
- edx.devstack.redis

zookeeper:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add some comments about what these containers are here, because without context, zookeeper and kafka are pretty confusing.

@rgraber
Copy link
Copy Markdown
Contributor Author

rgraber commented Nov 10, 2021

@timmc-edx confirmed it on linux so I'm going to go ahead and merge

@rgraber rgraber merged commit 37ff02e into master Nov 10, 2021
@rgraber rgraber deleted the rsgraber/ARHCBOM-1943-setup-kafka-in-devstack branch November 10, 2021 19:32
nsprenkle pushed a commit that referenced this pull request Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants