This repository was archived by the owner on Aug 1, 2024. It is now read-only.
feat: add kafka containers to devstack#854
Merged
Conversation
Contributor
|
Why is Kafka necessary in the devstack? |
Contributor
Author
We are in the process of developing an event bus for the platform, and for now kafka is our broker of choice. Adding it to devstack will be a big aid for local development. |
dianakhuang
approved these changes
Nov 10, 2021
Contributor
dianakhuang
left a comment
There was a problem hiding this comment.
Looks good on my machine, but I would recommend making sure a Linux dev also gives it a shot.
| aliases: | ||
| - edx.devstack.redis | ||
|
|
||
| zookeeper: |
Contributor
There was a problem hiding this comment.
I think we should add some comments about what these containers are here, because without context, zookeeper and kafka are pretty confusing.
Contributor
Author
|
@timmc-edx confirmed it on linux so I'm going to go ahead and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add kafka services to devstack. These include:
I've completed each of the following or determined they are not applicable: