This repository was archived by the owner on Aug 1, 2024. It is now read-only.
fix: bump node image for microfrontends for mozjpeg-bin#865
Merged
Conversation
adzuci
approved these changes
Dec 2, 2021
Contributor
adzuci
left a comment
There was a problem hiding this comment.
This seems reasonable to me, we may also want to make sure sandboxes and presumably anywhere else this is needed are in sync with devstack.
Also we may want to add this to a release note of some kind, but I'm not positive about that.
Contributor
Author
|
Thanks, everyone! |
ztraboo
pushed a commit
to CUCWD/devstack
that referenced
this pull request
Jan 12, 2022
…-devstack fix: bump node image for microfrontends for mozjpeg-bin
ztraboo
pushed a commit
to CUCWD/devstack
that referenced
this pull request
Jan 12, 2022
…-devstack fix: bump node image for microfrontends for mozjpeg-bin
This was referenced Jan 12, 2022
ztraboo
added a commit
to CUCWD/devstack
that referenced
this pull request
Jan 12, 2022
…ode-mozjpeg [Backport] Merge pull request openedx-unsupported#865 from edx/pshiu/add-zlib-to-devstack
cmltaWt0
added a commit
that referenced
this pull request
Jan 17, 2022
…node-mozjpeg [Backport] Merge pull request #865 from edx/pshiu/add-zlib-to-devstack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Our microfrontends depend on mozjpeg-bin, which requires zlib 1.2.9 as of mozjpeg-bin@7.1.1.
This PR bumps the OS image used by the microfrontends from Debian release 9 (
stretchor oldoldstable) to 11 (bullseyeor stable) to upgrade zlib to a better version.The bump is from:
node:12imagestretchTo:
node:12-bullseyeimageThis should fix errors like "Error: Cannot find module 'mozjpeg'".
Research
busterDebian image since it also is packed with zlib 1.2.11, but the thought is to upgrade further if possible.bullseye, so if the default changes in the future that will not be picked up.node:12-bullseyewith no problems for the past two days.git pullthis change into your devstack foldernode_modulesfolders in yourfrontend-app-*Git repositoriesgit pullin yourfrontend-app-*Git repositoriesmake dev.up.frontend-app-gradebook+frontend-app-payment+frontend-app-publisher+frontend-app-learningin your devstack folder to recreate your containers.I've completed each of the following or determined they are not applicable:
[ ] Made a plan to communicate any major developer interface changes (or N/A)