Skip to content
This repository was archived by the owner on Aug 1, 2024. It is now read-only.

fix: bump node image for microfrontends for mozjpeg-bin#865

Merged
pshiu merged 1 commit intomasterfrom
pshiu/add-zlib-to-devstack
Dec 3, 2021
Merged

fix: bump node image for microfrontends for mozjpeg-bin#865
pshiu merged 1 commit intomasterfrom
pshiu/add-zlib-to-devstack

Conversation

@pshiu
Copy link
Copy Markdown
Contributor

@pshiu pshiu commented Dec 2, 2021

Description

Our microfrontends depend on mozjpeg-bin, which requires zlib 1.2.9 as of mozjpeg-bin@7.1.1.

This PR bumps the OS image used by the microfrontends from Debian release 9 (stretch or oldoldstable) to 11 (bullseye or stable) to upgrade zlib to a better version.

The bump is from:

To:

This should fix errors like "Error: Cannot find module 'mozjpeg'".

Research

  • Other options: Here are all the Docker node image options: Docker Hub
  • What we use in prod: We use Ubuntu bionic (18.04 LTS) right now in GoCD to do our builds for staging & production: internal-dockerfiles (sorry non-edX folks, this is a private repo).
  • What zlib prod uses: Ubuntu bionic (18.04 LTS) is packed with zlib 1.2.11.
  • Why can't we use bionic?: Node on Docker Hub doesn't seem to offer Ubuntu Node images.
  • On choice of image: We could technically use the buster Debian image since it also is packed with zlib 1.2.11, but the thought is to upgrade further if possible.
  • On disadvantage of this PR: This does pin the image to bullseye, so if the default changes in the future that will not be picked up.
  • On testing: I have been using devstack with node:12-bullseye with no problems for the past two days.
  • On usage: To use this change:
    • git pull this change into your devstack folder
    • Clear out any node_modules folders in your frontend-app-* Git repositories
    • git pull in your frontend-app-* Git repositories
    • Run make dev.up.frontend-app-gradebook+frontend-app-payment+frontend-app-publisher+frontend-app-learning in your devstack folder to recreate your containers.

I've completed each of the following or determined they are not applicable:

  • [ ] Made a plan to communicate any major developer interface changes (or N/A)
    • N/A

@pshiu pshiu self-assigned this Dec 2, 2021
Copy link
Copy Markdown
Contributor

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Contributor

@adzuci adzuci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, we may also want to make sure sandboxes and presumably anywhere else this is needed are in sync with devstack.

Also we may want to add this to a release note of some kind, but I'm not positive about that.

@pshiu
Copy link
Copy Markdown
Contributor Author

pshiu commented Dec 3, 2021

Thanks, everyone!

@pshiu pshiu merged commit 19fdd17 into master Dec 3, 2021
@pshiu pshiu deleted the pshiu/add-zlib-to-devstack branch December 3, 2021 00:33
ztraboo pushed a commit to CUCWD/devstack that referenced this pull request Jan 12, 2022
…-devstack

fix: bump node image for microfrontends for mozjpeg-bin
ztraboo pushed a commit to CUCWD/devstack that referenced this pull request Jan 12, 2022
…-devstack

fix: bump node image for microfrontends for mozjpeg-bin
ztraboo added a commit to CUCWD/devstack that referenced this pull request Jan 12, 2022
…ode-mozjpeg

[Backport] Merge pull request openedx-unsupported#865 from edx/pshiu/add-zlib-to-devstack
cmltaWt0 added a commit that referenced this pull request Jan 17, 2022
…node-mozjpeg

[Backport] Merge pull request #865 from edx/pshiu/add-zlib-to-devstack
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants