feat: add frontend app authn#894
Conversation
6ce2320 to
1a13d17
Compare
1a13d17 to
5ca807b
Compare
5ca807b to
139fca1
Compare
|
@zainab-amir you asked in Slack:
First of all: No, I do not think the entire change needs to be reverted. It's good that the Authn MFE is available in devstack! The concern we found with the ADR you linked (described under "status: reverted") is that it would be unsustainable if starting the LMS also started dozens of MFEs automatically because of the high resource usage of each MFE's container. So, for the majority of MFEs, we decided that the LMS should not start them by default; instead, it's up to devstack users to start all the MFEs that they are going to use. By that logic, I would recommend that you keep the majority of this PR, but revert the part that makes LMS require Authn MFE, instead leaving it the MFE as an optional component. On the other hand, the Authn MFE is special because the login+registration flow is a gateway to almost every other feature of the platform... so, if the LMS were going to require a single MFE, it would be the Authn MFE. By that logic, it could be fine to leave this PR in place entirely. I do not have a strong opinion either way. If I had to give a personal recommendation, I would say just leave it as-is and reevaluate if it ever becomes a problem. Our current plan is to replace Devstack with Tutor, so hopefully you won't have to worry about this for long. |
|
I like @kdmccormick’s recommendation of making this an exception unless and until it becomes a problem. Two possible follow-ups:
|
|
Thank you for the thoughts @kdmccormick and @robrap! @zainab-amir I guess let's remove the Authn MFE from LMS dependency for now since it's not quite yet ready for the community until we complete the optional fields work. Once that is done, maybe we can then add it back and announce it community-wide. |
Ticket: https://openedx.atlassian.net/browse/VAN-315
I've completed each of the following or determined they are not applicable: