feat: add frontend-app-profile to DevStack#898
feat: add frontend-app-profile to DevStack#898dianakhuang merged 2 commits intoopenedx-unsupported:masterfrom
Conversation
Changes: - update README - add frontend-app-account service to docker-compose.yml - add frontend-app-account service to docker-compose-host.yml - add frontend-app-account to EDX_SERVICES in options.mk - add frontend-app-account repo to non_release_* repos in repo.sh
|
Thanks for the pull request, @cmltaWt0! I've created OSPR-6437 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
@cmltaWt0 Thank you for your contribution, is this ready for our review? |
|
@natabene Yeap. Totally. Thanks! |
dianakhuang
left a comment
There was a problem hiding this comment.
This looks good to me. I'm going to merge it. Thanks @cmltaWt0 !
|
@cmltaWt0 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Changes: - update README - add frontend-app-account service to docker-compose.yml - add frontend-app-account service to docker-compose-host.yml - add frontend-app-account to EDX_SERVICES in options.mk - add frontend-app-account repo to non_release_* repos in repo.sh
Changes:
Since Profile MFE is a part of Lilac+ release - there is clear demand to have it in default Devstack suit.
Issues:
Enabling Profile MFE in UI:
Site Configuration must be updated with this:
Also we have to add
PROFILE_MICROFRONTEND_URL = 'http://localhost:1995/u/'to lms.yml todevstack.py