Skip to content
This repository was archived by the owner on Aug 1, 2024. It is now read-only.

feat: add frontend-app-profile to DevStack#898

Merged
dianakhuang merged 2 commits intoopenedx-unsupported:masterfrom
cmltaWt0:master
Feb 22, 2022
Merged

feat: add frontend-app-profile to DevStack#898
dianakhuang merged 2 commits intoopenedx-unsupported:masterfrom
cmltaWt0:master

Conversation

@cmltaWt0
Copy link
Copy Markdown
Contributor

@cmltaWt0 cmltaWt0 commented Feb 4, 2022

Changes:

  • update README
  • add frontend-app-account service to docker-compose.yml
  • add frontend-app-account service to docker-compose-host.yml
  • add frontend-app-account to EDX_SERVICES in options.mk
  • add frontend-app-account repo to non_release_* repos in repo.sh

Since Profile MFE is a part of Lilac+ release - there is clear demand to have it in default Devstack suit.

Issues:

  • enabling Profile MFE in LMS UI requires following actions which can be done in lms provision step but probably must be done in configuration repo during docker image preparation step

Enabling Profile MFE in UI:

diff --git a/provision-lms.sh b/provision-lms.sh
index cd162ee..4caf868 100755
--- a/provision-lms.sh
+++ b/provision-lms.sh
 # Enable MFE
+docker-compose exec -T lms bash -e -c 'source /edx/app/edxapp/edxapp_env && python /edx/app/edxapp/edx-platform/manage.py lms waffle_flag --list --settings=devstack_docker | grep learner_profile.redirect_to_microfrontend || python /edx/app/edxapp/edx-platform/manage.py lms waffle_flag --create --everyone learner_profile.redirect_to_microfrontend --settings=devstack_docker'

Site Configuration must be updated with this:

{
  "ENABLE_PROFILE_MICROFRONTEND": true
}

Also we have to add PROFILE_MICROFRONTEND_URL = 'http://localhost:1995/u/' to lms.yml to devstack.py

Changes:
- update README
- add frontend-app-account service to docker-compose.yml
- add frontend-app-account service to docker-compose-host.yml
- add frontend-app-account to EDX_SERVICES in options.mk
- add frontend-app-account repo to non_release_* repos in repo.sh
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @cmltaWt0! I've created OSPR-6437 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Feb 4, 2022
@natabene
Copy link
Copy Markdown

natabene commented Feb 7, 2022

@cmltaWt0 Thank you for your contribution, is this ready for our review?

@openedx-webhooks openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels Feb 7, 2022
@cmltaWt0
Copy link
Copy Markdown
Contributor Author

cmltaWt0 commented Feb 7, 2022

@natabene Yeap. Totally. Thanks!

@openedx-webhooks openedx-webhooks added awaiting prioritization and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Feb 7, 2022
Copy link
Copy Markdown
Contributor

@dianakhuang dianakhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'm going to merge it. Thanks @cmltaWt0 !

@dianakhuang dianakhuang merged commit 7c47b22 into openedx-unsupported:master Feb 22, 2022
@openedx-webhooks
Copy link
Copy Markdown

@cmltaWt0 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

nsprenkle pushed a commit that referenced this pull request Nov 21, 2023
Changes:
- update README
- add frontend-app-account service to docker-compose.yml
- add frontend-app-account service to docker-compose-host.yml
- add frontend-app-account to EDX_SERVICES in options.mk
- add frontend-app-account repo to non_release_* repos in repo.sh
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

merged open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants