Skip to content
This repository was archived by the owner on Aug 1, 2024. It is now read-only.

feat: Added Opensearch 1.2.0#925

Merged
syedimranhassan merged 1 commit intomasterfrom
ihassan/added_opensearch_1_2_0
Apr 27, 2022
Merged

feat: Added Opensearch 1.2.0#925
syedimranhassan merged 1 commit intomasterfrom
ihassan/added_opensearch_1_2_0

Conversation

@syedimranhassan
Copy link
Copy Markdown
Contributor

@syedimranhassan syedimranhassan commented Apr 26, 2022


https://openedx.atlassian.net/browse/ISRE-1306
Adding OpenSearch for LMS, studio, cs_comments, and blockstore.
Our plan is to replace ES with OS for these services.

I've completed each of the following or determined they are not applicable:

  • Made a plan to communicate any major developer interface changes (or N/A)

Copy link
Copy Markdown
Contributor

@NIXKnight NIXKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread docker-compose.yml
- memcached
- mongo
- mysql57
- opensearch12
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can you update the PR description with a little more background about how and when each of the services will rely on this?
  2. Will this just be needed for a rare use case? I’m not clear on what “test OS upgrades” entails, but it seems like a more rare activity and that maybe this isn’t a required dependency for most uses of LMS or other services? This is a question. If not, maybe there should simply be doc changes for when and how to bring this container up?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the best reference for this is the Elasticsearch -> OpenSearch ticket we have on the DEPR board. We are migrating all our services off Elasticsearch and for those that can't use MySQL full text search, we're going to use OpenSearch. openedx/public-engineering#16

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we are migrating LMS, studio, cs_comments(forum), and blockstore from Elasticsearch -> OpenSearch.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Seems fine if you think we need both dependencies now.

@syedimranhassan syedimranhassan force-pushed the ihassan/added_opensearch_1_2_0 branch from 5ceae31 to 4e08941 Compare April 27, 2022 05:53
@syedimranhassan syedimranhassan merged commit 03eb127 into master Apr 27, 2022
@syedimranhassan syedimranhassan deleted the ihassan/added_opensearch_1_2_0 branch April 27, 2022 06:41
nsprenkle pushed a commit that referenced this pull request Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants