This repository was archived by the owner on May 1, 2024. It is now read-only.
fix: have elasticsearch return all items#486
Merged
Conversation
alangsto
force-pushed
the
alangsto/remove_custom_pagination
branch
3 times, most recently
from
095741a to
11e1178
Compare
matthugs
approved these changes
Sep 17, 2021
Contributor
matthugs
left a comment
matthugs
left a comment
There was a problem hiding this comment.
modulo missing update to tests, which were present in our last iteration of this fix
alangsto
force-pushed
the
alangsto/remove_custom_pagination
branch
from
11e1178 to
43aeda6
Compare
Codecov Report
@@ Coverage Diff @@
## master #486 +/- ##
=======================================
Coverage 97.28% 97.29%
=======================================
Files 56 56
Lines 3612 3617 +5
Branches 319 319
=======================================
+ Hits 3514 3519 +5
Misses 69 69
Partials 29 29
Continue to review full report at Codecov.
|
This was referenced Sep 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ES searches are only returning 10 results when we use
execute. We tried to return the total amount of documents using execute here https://github.com/edx/edx-analytics-data-api/pull/484, but courses with more than 10,000 learners would error out due to the result window being too large.Scan does not have this same limitation, however, it may cause memory pressure. I believe that this PR would at least cause the behavior of the learner endpoint to be consistent with its performance pre ES/ES-dsl library upgrade.