fix: only enable automerge when PR is created in update-browserslist-db#161
Merged
feanil merged 1 commit intoopenedx:masterfrom Jan 6, 2025
Merged
Conversation
brobro10000
approved these changes
Jan 6, 2025
feanil
approved these changes
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a run of the recent changes to
update-browserslist-db, it was observed that when no diff is created when updating thebrowserslistDB, we correctly skip the "auto-approve" step, but still attempt to run the "enable auto-merge" step, resulting in an error as there is not a valid PR number generated without a diff.Note: this no diff case will occur any time the workflow is run without any changes the
browserslistDB (e.g., on consecutive runs).