feat!: correcting the typography of this brand theme.#40
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ddd85634c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1 +1 @@ | |||
| // Add any font imports or definitions here | |||
| @import url('https://fonts.googleapis.com/css2?family=Inter:wght@400;500;700&family=Roboto+Mono&display=swap'); | |||
There was a problem hiding this comment.
paragon/_variables.scss sets $display1-weight through $display4-weight to 900, but paragon/_fonts.scss only loads Inter weights 400;500;700. In browsers, display text requesting font-weight: 900 will fall back to a synthesized or lower weight, so the new typography won’t render as intended for .display-* styles. Add 900 to the Google Fonts import (or lower display weights) to keep the configured typography consistent.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
No objections.
I'm going to squash the commits, though, and add the following to the bottom, otherwise we won't get a new major version from semantic-release:
BREAKING CHANGE: replaces default Paragon typography with
Inter/Roboto Mono font families and a revised heading scale
matching the [elm theme](https://github.com/edx/elm-theme).
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
This theme has been using the wrong fonts since it was created. It should be using the same fonts as the elm theme.