Skip to content

Add Travis and other automatic testing#4

Merged
tuchfarber merged 1 commit into
masterfrom
tuchfarber/add_ci
Aug 10, 2020
Merged

Add Travis and other automatic testing#4
tuchfarber merged 1 commit into
masterfrom
tuchfarber/add_ci

Conversation

@tuchfarber

Copy link
Copy Markdown
Contributor

No description provided.

@tuchfarber tuchfarber force-pushed the tuchfarber/add_ci branch 8 times, most recently from dc8869d to f240cdc Compare August 5, 2020 01:46
@codecov

codecov Bot commented Aug 5, 2020

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@3ecc02c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master      #4   +/-   ##
========================================
  Coverage          ?   0.00%           
========================================
  Files             ?       7           
  Lines             ?     533           
  Branches          ?       0           
========================================
  Hits              ?       0           
  Misses            ?     533           
  Partials          ?       0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ecc02c...d4b3a07. Read the comment docs.

@staubina

staubina commented Aug 5, 2020

Copy link
Copy Markdown

@kaizoku @0x29a

Comment thread tox.ini
@@ -1,7 +1,7 @@
[tox]
envlist = py35, py38, flake8

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

py3.5 added here intentionally after this comment in 5ed1eaa as well as some type casts of path for functions that lack support of pathlib.

And indeed, lms container of the devstack has python with version 3.5.2.

@kaizoku

kaizoku commented Aug 6, 2020

Copy link
Copy Markdown
Contributor

The tests runners look good to me. I'd like to test with the updated requirements, and the python requirement in my devstack, though my devstack is reprovisioning at the moment. I'll have some time to test installation and conversion tomorrow.

@tuchfarber

Copy link
Copy Markdown
Contributor Author

I've move the files back to 3.5/3.8 instead of 3.6. Re-ran make upgrade and requirements files didn't change, so I'm assuming they're all 3.5/3.6 compatible. I'm out tomorrow, but @staubina can merge this once you're good with it 👍

@0x29a

0x29a commented Aug 7, 2020

Copy link
Copy Markdown
Contributor

Thanks, @tuchfarber.

@kaizoku

kaizoku commented Aug 7, 2020

Copy link
Copy Markdown
Contributor

Thanks for updating that @tuchfarber.
I tested installing the test requirements in my devstack. We won't need to ordinarily install the dev and test requirements in the devstack, but if we add other runtime requirements later we'll want to be sure they're 3.5 compatible for integration.

twine 3.2.0 wasn't compatible with python <3.6, and after running make upgrade from python 3.5.9 I saw some changes to requirements that made them compatible I'm not against merging this as is, since it works fine for the test runners, but should I add the commit with the requirements changes I'm getting?

@staubina

staubina commented Aug 7, 2020

Copy link
Copy Markdown

@kaizoku, @tuchfarber is unavailable today. I think he is looking at putting 3.5 back into the files and doing a little local testing. We will update Monday.

@tuchfarber

Copy link
Copy Markdown
Contributor Author

I tried running make upgrade using 3.5.9 from deadsnakes, but the lack of requirements changing makes me think it didn't work correctly. I'd be fine if someone commits the requirement upgrades on this branch since I'm out. If not I'll tackle it on Monday

@0x29a

0x29a commented Aug 8, 2020

Copy link
Copy Markdown
Contributor

@tuchfarber

I'd be fine if someone commits the requirement upgrades on this branch since I'm out. If not I'll tackle it on Monday

I have no rights to push in this branch.

You can cherry-pick this: open-craft@b25dbb9

@tuchfarber

Copy link
Copy Markdown
Contributor Author

Sorry about that. I got the requirements back to 3.5 compatible (note twine back to 1.15). Waiting for tests to run, then I'll squash and merge.

Add travis with quality and pytest builds.
Add codecov config
Add make commands for installing requirements and upgrading
requirements.
@tuchfarber tuchfarber merged commit d5faec9 into master Aug 10, 2020
@kaizoku

kaizoku commented Aug 11, 2020

Copy link
Copy Markdown
Contributor

No worries @tuchfarber. The twine requirement was the primary one not compatible with 3.5.
Thanks again for configuring the test runners!

@nedbat nedbat deleted the tuchfarber/add_ci branch February 2, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants