[BD-27][TNL-7891][BB-3539] Remove Empty Sections from cc2olx Conversions - ContextModuleSubHeader#44
Conversation
|
Thanks for the pull request, @shimulch! I've created BLENDED-765 to keep track of it in Jira. More details are on the BD-27 project page. When this pull request is ready, tag your edX technical lead. |
| if not course_root: | ||
| return | ||
| sections = course_root.get("children", []) | ||
| sections = self.process_canvas_cc(course_root.get("children", [])) |
There was a problem hiding this comment.
Should we run this in all cases, or only run this transformation for canvas flavored common cartridges?
We can check if course_settings/canvas_export.txt exists to determine if this is a canvas flavored CC.
Canvas writes this file to determine if it's from a canvas export.
There was a problem hiding this comment.
@kaizoku, Thanks for the suggestion. Yeah this approach would be better. I've updated my PR.
|
Thanks for the PR @shimulch.
|
This PR fixes an issue related to empty sections while there are
canvasitems with content typeContextModuleSubHeader. With this PR,cc2olxwill treat these types of items assubsectionsand collapse related (consecutive) items under it asverticals.JIRA tickets:
Discussions:Dependencies: None
Screenshots:Sandbox URL:Merge deadline: None
Testing instructions:
imsccfile that containsContextModuleSubHeader, you can use the updated fixture with this PR.cc2olx.ContextModuleSubHeadercollapsed into it as verticals.Author notes and concerns:
N/A
Reviewers