Skip to content

[BD-21] Add support for warnings in the featuretoggles Sphinx extension#47

Merged
robrap merged 1 commit intoopenedx:masterfrom
regisb:regisb/featuretoggle-warnings
Aug 25, 2020
Merged

[BD-21] Add support for warnings in the featuretoggles Sphinx extension#47
robrap merged 1 commit intoopenedx:masterfrom
regisb:regisb/featuretoggle-warnings

Conversation

@regisb
Copy link
Copy Markdown
Contributor

@regisb regisb commented Aug 25, 2020

Description: Add support for toggle_warning flags in the featuretoggles Sphinx extension

JIRA: https://openedx.atlassian.net/wiki/spaces/COMM/pages/1596358943

Dependencies: None. But useful for documenting edx-platform feature toggles.

Reviewers:

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • [ ] Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPi after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program needs triage labels Aug 25, 2020
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @regisb! I've created BLENDED-560 to keep track of it in Jira. More details are on the BD-21 project page.

When this pull request is ready, tag your edX technical lead.

@robrap robrap merged commit 12dc1a7 into openedx:master Aug 25, 2020
@robrap
Copy link
Copy Markdown
Contributor

robrap commented Aug 25, 2020

@regisb: Thanks. FYI: For the future, this should have been a minor version update. See https://open-edx-proposals.readthedocs.io/en/latest/oep-0047-bp-semantic-versioning.html Thanks.

@regisb regisb deleted the regisb/featuretoggle-warnings branch August 27, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blended PR is managed through 2U's blended developmnt program merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants