Skip to content

Conversation

@morenol
Copy link
Contributor

@morenol morenol commented Jul 14, 2020

Change the way to check if it is running in a virtualenv in order to be compatible with virtualenv>20.0.0 and virtualenv<20.0.0 (currently used in the platform)

I separated the change in three commits, so you can see that
1- in the first commit (using virtualenv<20.0.0) it is failing,
2- In the second commit, the changes fixed the problem for virtualenv<20.0.0
3- in the third commit we are using again virtualenv>20.0.0 and it is working

Reviewers

@openedx-webhooks
Copy link

Thanks for the pull request, @morenol! I've created OSPR-4822 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Jul 14, 2020
@morenol morenol changed the title Use old version of virtualenv [BD-6] Use old version of virtualenv Jul 14, 2020
@morenol morenol force-pushed the lmm/virtualenv branch 4 times, most recently from 04febd1 to 6291e22 Compare July 14, 2020 19:14
@morenol morenol changed the title [BD-6] Use old version of virtualenv [BD-6] Fix check of virtualenv for virtualenv<20.0.0 Jul 14, 2020
@morenol morenol marked this pull request as ready for review July 14, 2020 19:23
Bump version  3.0.0 --> 3.0.1
@feanil feanil merged commit ffec49b into openedx:master Jul 15, 2020
@openedx-webhooks
Copy link

@morenol 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program merged and removed needs triage open-source-contribution PR author is not from Axim or 2U labels Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blended PR is managed through 2U's blended developmnt program merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants