Skip to content

Conversation

@gabor-boros
Copy link
Contributor

Description

This PR removes Celery<5 pin from requirements, so resolves a dependency conflict in openedx/edx-platform#29046.

Supporting information

For more information, please see the linked PR.

Signed-off-by: Gabor Boros <gabor.brs@gmail.com>
@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Feb 8, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @gabor-boros! I've created OSPR-6443 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #199 (530161a) into master (fbaa4b8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #199   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          412       412           
  Branches        64        64           
=========================================
  Hits           412       412           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
user_tasks/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbaa4b8...530161a. Read the comment docs.

@awais786 awais786 self-requested a review February 9, 2022 10:16
@gabor-boros
Copy link
Contributor Author

@awais786 Thank you for the review! Please not that it would require a release as well to profit get unblocked on Celery side.

@iamsobanjaved iamsobanjaved merged commit 1a79ad8 into openedx:master Feb 9, 2022
@openedx-webhooks
Copy link

@gabor-boros 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@iamsobanjaved
Copy link
Contributor

@gabor-boros I have merged this PR and also released the new version.

@gabor-boros
Copy link
Contributor Author

Thank you @iamsobanjaved! We are one step closer

@gabor-boros gabor-boros deleted the gabor/bump-celery branch February 10, 2022 11:37
@natabene
Copy link

@gabor-boros Thank you for your contribution. @iamsobanjaved Thanks for reviewing and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants