Skip to content

fix: remove codecov package requirement #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
UsamaSadiq merged 2 commits into from
Apr 25, 2023
Merged

fix: remove codecov package requirement #275

UsamaSadiq merged 2 commits into from
Apr 25, 2023

Conversation

@UsamaSadiq
Copy link
Member

@UsamaSadiq UsamaSadiq commented Apr 17, 2023

Description

  • Codecov deprecated the pypi package long ago (Feb 2022) but left it up until now.
  • Removing the package from requirements to fix the failing upgrade job.
  • The Github Action we use to upload to codecov doesn’t depend on the package so our CI coverage won’t be affected by the change.

@UsamaSadiq UsamaSadiq merged commit 826da5e into master Apr 25, 2023
@UsamaSadiq UsamaSadiq deleted the usamasadiq/remove-codecov-package-from-requirements branch April 25, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@iamsobanjaved iamsobanjaved iamsobanjaved approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@UsamaSadiq @iamsobanjaved