Skip to content

Conversation

@bmtcril
Copy link
Contributor

@bmtcril bmtcril commented Nov 25, 2024

Per OEP-30 these annotations should live with their models. I'm just moving them from the edx-platform safelist to their correct home.

Per OEP-30 these annotations should live with their models. I'm just
moving them from the edx-platform safelist to their correct home.
@codecov
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (20e4e6e) to head (4ede87d).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #388   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          433       433           
  Branches        47        47           
=========================================
  Hits           433       433           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but consider releasing a patch version otherwise this might never go out :P

@bmtcril bmtcril merged commit 9e381de into master Dec 2, 2024
17 checks passed
@bmtcril bmtcril deleted the bmtcril/pii_annotations branch December 2, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants