Skip to content

Increase largest max width#21

Merged
andy-armstrong merged 1 commit intomasterfrom
andya/tweak-max-widths
Nov 1, 2017
Merged

Increase largest max width#21
andy-armstrong merged 1 commit intomasterfrom
andya/tweak-max-widths

Conversation

@andy-armstrong
Copy link
Contributor

@andy-armstrong andy-armstrong commented Oct 31, 2017

@HarryRein
Copy link
Contributor

HarryRein commented Oct 31, 2017

It looks like the learner profile is having issues with the new rule for max-width. We probably want to remove that dependency in the profile. Check out the styling on the content-wrapper.

Also, the courseware has a max width that makes this a bit quirky. Will your other story finish that?

screen shot 2017-10-31 at 3 40 36 pm
screen shot 2017-10-31 at 3 42 04 pm

@andy-armstrong
Copy link
Contributor Author

@HarryRein The courseware max width was a deliberate decision to make HTML and CAPA blocks have a max width of 900px. It mostly looks okay, but the example you show is a little odd due to the giant floated image. I think it is a net improvement but we can discuss whether there's anything to do with @marcotuts.

@andy-armstrong
Copy link
Contributor Author

@HarryRein Let's discuss on the other PR. I'd like to release this one as is if that's okay with you. Can you give me thumbs for just the changes here.

@andy-armstrong andy-armstrong merged commit f0a6237 into master Nov 1, 2017
@andy-armstrong andy-armstrong deleted the andya/tweak-max-widths branch November 1, 2017 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants