Merged
Conversation
7 tasks
Contributor
Contributor
Author
|
@HarryRein The courseware max width was a deliberate decision to make HTML and CAPA blocks have a max width of 900px. It mostly looks okay, but the example you show is a little odd due to the giant floated image. I think it is a net improvement but we can discuss whether there's anything to do with @marcotuts. |
Contributor
Author
|
@HarryRein Let's discuss on the other PR. I'd like to release this one as is if that's okay with you. Can you give me thumbs for just the changes here. |
HarryRein
approved these changes
Nov 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR makes the largest max width 1920 instead of 1280, to better support wider screens.
See https://github.com/edx/edx-platform/pull/16391 for its usage in edx-platform.
Sandbox: https://andy-armstrong.sandbox.edx.org/courses/course-v1:edX+DemoX+Demo_Course/courseware/interactive_demonstrations/19a30717eff543078a5d94ae9d6c18a5/?child=first