feat!: Remove newrelic from base dependencies #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will reduce the dependency set for deployers not using New Relic. See DEPR: openedx/public-engineering#360 Also, update docs around choice of backends.
6 tasks
robrap
approved these changes
May 22, 2025
| -------------------------- | ||
|
|
||
| The most complete feature support is for New Relic (the default), but there is also initial support for OpenTelemetry and Datadog. | ||
| The most complete feature support is for New Relic (the default), but there is also relatively complete support for Datadog and preliminary support for OpenTelemetry. Private or alternative implementations can also be used. |
There was a problem hiding this comment.
This change made me wonder about;
- Is anyone using New Relic, and should it be DEPRed entirely rather than maintained?
- Whether the backends should be a part of the repo or pluggable? There are pros and cons.
Neither of these comments block or change this work.
There was a problem hiding this comment.
Yeah, good questions. Having the backends here means it's easier to notice when an API addition or change is overly specific to one backend's structure, but obviously it also increases maintenance burden.
(I don't think pluggable is in opposition to in-repo, though -- one could already use an implementation that's out-of-repo.)
I think my strongest preference is that we should figure out how to switch everything to OpenTelemetry, if possible. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will reduce the dependency set for deployers not using New Relic. See DEPR: openedx/public-engineering#360
Also, update docs around choice of backends.
Merge checklist: