Skip to content

ENT-8277 - feat: register admin view for IntegratedChannelAPIRequestLogs#2015

Merged
hamzawaleed01 merged 2 commits into
masterfrom
ENT-8277-register-admin-view
Feb 7, 2024
Merged

ENT-8277 - feat: register admin view for IntegratedChannelAPIRequestLogs#2015
hamzawaleed01 merged 2 commits into
masterfrom
ENT-8277-register-admin-view

Conversation

@hamzawaleed01
Copy link
Copy Markdown
Contributor

@hamzawaleed01 hamzawaleed01 commented Feb 6, 2024

Merge checklist:

  • Any new requirements are in the right place (do not manually modify the requirements/*.txt files)
    • base.in if needed in production but edx-platform doesn't install it
    • test-master.in if edx-platform pins it, with a matching version
    • make upgrade && make requirements have been run to regenerate requirements
  • make static has been run to update webpack bundling if any static content was updated
  • ./manage.py makemigrations has been run
    • Checkout the Database Migration Confluence page for helpful tips on creating migrations.
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.
    • This should be run from either a venv with all the lms/edx-enterprise requirements installed or if you checked out edx-enterprise into the src directory used by lms, you can run this command through an lms shell.
      • It would be ./manage.py lms makemigrations in the shell.
  • Version bumped
  • Changelog record added
  • Translations updated (see docs/internationalization.rst but also this isn't blocking for merge atm)

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in GitHub Actions, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in edx-platform to upgrade dependencies (including edx-enterprise)
    • This must be done after the version is visible in PyPi as make upgrade in edx-platform will look for the latest version in PyPi.
    • Note: the edx-enterprise constraint in edx-platform must also be bumped to the latest version in PyPi.

@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8277-register-admin-view branch from 0e91b51 to 11b360a Compare February 6, 2024 11:41
Copy link
Copy Markdown
Contributor

@MueezKhan246 MueezKhan246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8277-register-admin-view branch from 11b360a to 7787131 Compare February 6, 2024 11:49
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8277-register-admin-view branch from d91af2a to 45d85cb Compare February 7, 2024 06:46
@hamzawaleed01 hamzawaleed01 merged commit 3c3b17c into master Feb 7, 2024
@hamzawaleed01 hamzawaleed01 deleted the ENT-8277-register-admin-view branch February 7, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants