[ENT-8931] - Update is_already_transmitted util logic#2121
Merged
Conversation
…931/schema-improvement-integrate-channels
6f5a425 to
0d07e17
Compare
…931/schema-improvement-integrate-channels
0d07e17 to
09bffc4
Compare
…ub.com:openedx/edx-enterprise into ENT-8931/update-already-transmitted-logic
zamanafzal
reviewed
Jun 4, 2024
Member
zamanafzal
left a comment
There was a problem hiding this comment.
LGTM but we can't merge it until management command from this PR is not executed on production.
a6004cc to
3d19dcc
Compare
Base automatically changed from
ENT-8931/schema-improvement-integrate-channels
to
master
June 4, 2024 09:39
…931/update-already-transmitted-logic
5ab9716 to
930e045
Compare
…931/update-already-transmitted-logic
0df96b5 to
fe95f31
Compare
zamanafzal
approved these changes
Jun 11, 2024
fe95f31 to
76d81a3
Compare
…931/update-already-transmitted-logic
76d81a3 to
1da6860
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge checklist:
requirements/*.txtfiles)base.inif needed in production but edx-platform doesn't install ittest-master.inif edx-platform pins it, with a matching versionmake upgrade && make requirementshave been run to regenerate requirementsmake statichas been run to update webpack bundling if any static content was updated./manage.py makemigrationshas been run./manage.py lms makemigrationsin the shell.Post merge:
(so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
make upgradein edx-platform will look for the latest version in PyPi.