Skip to content

[ENT-8931] - Update is_already_transmitted util logic#2121

Merged
hamzawaleed01 merged 7 commits into
masterfrom
ENT-8931/update-already-transmitted-logic
Jun 11, 2024
Merged

[ENT-8931] - Update is_already_transmitted util logic#2121
hamzawaleed01 merged 7 commits into
masterfrom
ENT-8931/update-already-transmitted-logic

Conversation

@hamzawaleed01
Copy link
Copy Markdown
Contributor

@hamzawaleed01 hamzawaleed01 commented Jun 3, 2024

Merge checklist:

  • Any new requirements are in the right place (do not manually modify the requirements/*.txt files)
    • base.in if needed in production but edx-platform doesn't install it
    • test-master.in if edx-platform pins it, with a matching version
    • make upgrade && make requirements have been run to regenerate requirements
  • make static has been run to update webpack bundling if any static content was updated
  • ./manage.py makemigrations has been run
    • Checkout the Database Migration Confluence page for helpful tips on creating migrations.
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.
    • This should be run from either a venv with all the lms/edx-enterprise requirements installed or if you checked out edx-enterprise into the src directory used by lms, you can run this command through an lms shell.
      • It would be ./manage.py lms makemigrations in the shell.
  • Version bumped
  • Changelog record added
  • Translations updated (see docs/internationalization.rst but also this isn't blocking for merge atm)

Post merge:

  • Tag pushed and a new version released
    • Note: Assets will be added automatically. You just need to provide a tag (should match your version number) and title and description.
  • After versioned build finishes in GitHub Actions, verify version has been pushed to PyPI
    • Each step in the release build has a condition flag that checks if the rest of the steps are done and if so will deploy to PyPi.
      (so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
  • PR created in edx-platform to upgrade dependencies (including edx-enterprise)
    • Trigger the 'Upgrade one Python dependency' action against master in edx-platform with new version number to generate version bump PR
    • This must be done after the version is visible in PyPi as make upgrade in edx-platform will look for the latest version in PyPi.
    • Note: the edx-enterprise constraint in edx-platform must also be bumped to the latest version in PyPi.

@hamzawaleed01 hamzawaleed01 changed the base branch from master to ENT-8931/schema-improvement-integrate-channels June 3, 2024 07:08
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8931/schema-improvement-integrate-channels branch 2 times, most recently from 6f5a425 to 0d07e17 Compare June 3, 2024 09:54
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8931/schema-improvement-integrate-channels branch from 0d07e17 to 09bffc4 Compare June 3, 2024 10:45
…ub.com:openedx/edx-enterprise into ENT-8931/update-already-transmitted-logic
Copy link
Copy Markdown
Member

@zamanafzal zamanafzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we can't merge it until management command from this PR is not executed on production.

@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8931/schema-improvement-integrate-channels branch 3 times, most recently from a6004cc to 3d19dcc Compare June 4, 2024 09:26
Base automatically changed from ENT-8931/schema-improvement-integrate-channels to master June 4, 2024 09:39
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8931/update-already-transmitted-logic branch from 5ab9716 to 930e045 Compare June 4, 2024 11:41
@hamzawaleed01 hamzawaleed01 requested a review from zamanafzal June 11, 2024 08:10
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8931/update-already-transmitted-logic branch 3 times, most recently from 0df96b5 to fe95f31 Compare June 11, 2024 09:09
Comment thread CHANGELOG.rst Outdated
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8931/update-already-transmitted-logic branch from fe95f31 to 76d81a3 Compare June 11, 2024 09:16
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-8931/update-already-transmitted-logic branch from 76d81a3 to 1da6860 Compare June 11, 2024 09:17
@hamzawaleed01 hamzawaleed01 merged commit 1894b3b into master Jun 11, 2024
@hamzawaleed01 hamzawaleed01 deleted the ENT-8931/update-already-transmitted-logic branch June 11, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants