Skip to content

Conversation

@xitij2000
Copy link
Contributor

@xitij2000 xitij2000 commented Apr 3, 2025

The context menu in the TinyMCE editor only displayed a "Link" option but as a result disabled the browser-native context menu which includes more useful actions. This change disables the context menu.

What changed?

  • TinyMCE's default context menu is disabled

Developer Checklist

Testing Instructions

Install the XBlock and see that the context menu in TinyMCE is disabled.

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 3, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 3, 2025

Thanks for the pull request, @xitij2000!

This repository is currently maintained by @openedx/2u-aurora.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Apr 3, 2025
@xitij2000 xitij2000 marked this pull request as draft April 3, 2025 11:02
@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.29%. Comparing base (628d44f) to head (075a0b8).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2289   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files         195      195           
  Lines       21663    21663           
  Branches     1509     1509           
=======================================
  Hits        20643    20643           
  Misses        771      771           
  Partials      249      249           
Flag Coverage Δ
unittests 95.29% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pomegranited
Copy link
Contributor

Hi @xitij2000 , ping me on the Jira ticket if you need help getting this merged? I'm CC on this repo.

Copy link

@kaustavb12 kaustavb12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: Tested in local setup
  • I read through the code

@xitij2000 xitij2000 marked this pull request as ready for review April 4, 2025 15:04
@itsjeyd itsjeyd added core contributor PR author is a Core Contributor (who may or may not have write access to this repo). product review PR requires product review before merging labels Apr 10, 2025
@itsjeyd itsjeyd moved this from Needs Triage to Waiting on Author in Contributions Apr 10, 2025
@itsjeyd itsjeyd moved this from Waiting on Author to Product Review in Contributions May 8, 2025
@xitij2000 xitij2000 force-pushed the kshitij/disable-context-menu branch from 9416236 to 9889333 Compare June 12, 2025 08:39
@itsjeyd itsjeyd added product review complete PR has gone through product review and removed product review PR requires product review before merging labels Jul 25, 2025
@itsjeyd itsjeyd moved this from Product Review to Waiting on Author in Contributions Jul 25, 2025
@itsjeyd
Copy link

itsjeyd commented Jul 25, 2025

@xitij2000 Now that this change has product approval, could you please resolve merge conflicts here and fix the failing tests so we can put this up for a final round of review?

@xitij2000 xitij2000 force-pushed the kshitij/disable-context-menu branch from 9889333 to 4d10bf9 Compare July 28, 2025 11:05
@xitij2000
Copy link
Contributor Author

@itsjeyd I've resolved the issue, but the test failures seem to be unrelated. Will push again so check.

@xitij2000 xitij2000 force-pushed the kshitij/disable-context-menu branch from 94461d0 to 0945da3 Compare July 29, 2025 08:54
@xitij2000
Copy link
Contributor Author

The tests seems to pass locally but fail here. This particular test seems to be flaky since it's also failing on other PRs. I'll push again and see how it goes.

@pomegranited
Copy link
Contributor

@xitij2000 JS tests are always flaky.. I'll re-run.

@xitij2000 xitij2000 force-pushed the kshitij/disable-context-menu branch from 87c06f6 to 0945da3 Compare July 31, 2025 18:21
@itsjeyd
Copy link

itsjeyd commented Aug 7, 2025

Hey @pomegranited! 🙂 👋 It looks like we got a green build here. Let us know when you'd be able to give this a final look?

@itsjeyd itsjeyd moved this from Waiting on Author to Ready for Review in Contributions Aug 8, 2025
@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Aug 8, 2025
@itsjeyd itsjeyd requested a review from pomegranited August 8, 2025 08:39
@itsjeyd
Copy link

itsjeyd commented Aug 25, 2025

@pomegranited Do you think you'll have time to come back to this PR in the coming days? Happy to ping someone else for final 👍 if not; just let me know.

@itsjeyd itsjeyd requested a review from a team September 9, 2025 07:53
@itsjeyd
Copy link

itsjeyd commented Sep 9, 2025

Hi @openedx/2u-aurora team, could you please help get this small PR merged?

@itsjeyd itsjeyd added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Sep 9, 2025
@itsjeyd
Copy link

itsjeyd commented Sep 23, 2025

Hi @openedx/committers-edx-ora2, we still need a review on this small PR. Could one of you please help get it merged?

@itsjeyd itsjeyd requested review from a team and removed request for a team and pomegranited September 23, 2025 07:19
@itsjeyd
Copy link

itsjeyd commented Oct 14, 2025

@openedx/axim-engineering There seem to be no takers for reviewing this PR at the moment (I also posted on Slack about it last week).

It has been waiting for engineering review since early August, so I was wondering if one of you could help with getting it over the line?

@brian-smith-tcril
Copy link

The context menu in the TinyMCE editor only displayed a "Link" option but as a result disabled the browser-native context menu which includes more useful actions. This change disables the context menu.

I just want to confirm we aren't losing any functionality here. Is there still a way to add a link after this change?

@xitij2000
Copy link
Contributor Author

The context menu in the TinyMCE editor only displayed a "Link" option but as a result disabled the browser-native context menu which includes more useful actions. This change disables the context menu.

I just want to confirm we aren't losing any functionality here. Is there still a way to add a link after this change?

There are alternative ways to add links using the toolbar or shortcuts. The feature as-is takes over the default browser context menu and as such masks any features and functionality provided by the browsers, so if anything this change to restore browser features that are curretly obscured.

@brian-smith-tcril
Copy link

There are alternative ways to add links using the toolbar or shortcuts.

I figured that was the case but just wanted to verify and document that on this PR.

The last question I have here is about the developer checklist part of the PR template. I see it mentions bumping the version in package.json and this PR doesn't do that. Is that an outdated requirement or just something missed in this PR?

@itsjeyd itsjeyd moved this from Ready for Review to In Eng Review in Contributions Oct 16, 2025
@itsjeyd itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. needs reviewer assigned PR needs to be (re-)assigned a new reviewer labels Oct 16, 2025
The context menu in the TinyMCE editor only displayed a "Link" option but as a
result disabled the browser-native context menu which includes more useful
actions. This change disables the context menu.
@xitij2000 xitij2000 force-pushed the kshitij/disable-context-menu branch from 0945da3 to 075a0b8 Compare October 16, 2025 10:25
@xitij2000
Copy link
Contributor Author

The last question I have here is about the developer checklist part of the PR template. I see it mentions bumping the version in package.json and this PR doesn't do that. Is that an outdated requirement or just something missed in this PR?

I've updated the version in package.json. sorry for missing that step.

Copy link

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Oct 17, 2025
@itsjeyd itsjeyd moved this from In Eng Review to Ready to Merge in Contributions Oct 17, 2025
@itsjeyd
Copy link

itsjeyd commented Oct 17, 2025

Thanks a lot for jumping in here @brian-smith-tcril!

Neither @xitij2000 nor I have merge rights for this repo, so if you could it the button for us when you're ready, that would be great.

@brian-smith-tcril brian-smith-tcril merged commit 430b908 into openedx:master Oct 17, 2025
13 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Merge to Done in Contributions Oct 17, 2025
@xitij2000 xitij2000 deleted the kshitij/disable-context-menu branch October 23, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U product review complete PR has gone through product review

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants