-
Notifications
You must be signed in to change notification settings - Fork 209
fix: Disable context-menu on right-click in TinyMCE #2289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Disable context-menu on right-click in TinyMCE #2289
Conversation
|
Thanks for the pull request, @xitij2000! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2289 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 195 195
Lines 21663 21663
Branches 1509 1509
=======================================
Hits 20643 20643
Misses 771 771
Partials 249 249
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @xitij2000 , ping me on the Jira ticket if you need help getting this merged? I'm CC on this repo. |
kaustavb12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: Tested in local setup
- I read through the code
9416236 to
9889333
Compare
|
@xitij2000 Now that this change has product approval, could you please resolve merge conflicts here and fix the failing tests so we can put this up for a final round of review? |
9889333 to
4d10bf9
Compare
|
@itsjeyd I've resolved the issue, but the test failures seem to be unrelated. Will push again so check. |
94461d0 to
0945da3
Compare
|
The tests seems to pass locally but fail here. This particular test seems to be flaky since it's also failing on other PRs. I'll push again and see how it goes. |
|
@xitij2000 JS tests are always flaky.. I'll re-run. |
87c06f6 to
0945da3
Compare
|
Hey @pomegranited! 🙂 👋 It looks like we got a green build here. Let us know when you'd be able to give this a final look? |
|
@pomegranited Do you think you'll have time to come back to this PR in the coming days? Happy to ping someone else for final 👍 if not; just let me know. |
|
Hi @openedx/2u-aurora team, could you please help get this small PR merged? |
|
Hi @openedx/committers-edx-ora2, we still need a review on this small PR. Could one of you please help get it merged? |
|
@openedx/axim-engineering There seem to be no takers for reviewing this PR at the moment (I also posted on Slack about it last week). It has been waiting for engineering review since early August, so I was wondering if one of you could help with getting it over the line? |
I just want to confirm we aren't losing any functionality here. Is there still a way to add a link after this change? |
There are alternative ways to add links using the toolbar or shortcuts. The feature as-is takes over the default browser context menu and as such masks any features and functionality provided by the browsers, so if anything this change to restore browser features that are curretly obscured. |
I figured that was the case but just wanted to verify and document that on this PR. The last question I have here is about the developer checklist part of the PR template. I see it mentions bumping the version in |
The context menu in the TinyMCE editor only displayed a "Link" option but as a result disabled the browser-native context menu which includes more useful actions. This change disables the context menu.
0945da3 to
075a0b8
Compare
I've updated the version in package.json. sorry for missing that step. |
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Thanks a lot for jumping in here @brian-smith-tcril! Neither @xitij2000 nor I have merge rights for this repo, so if you could it the button for us when you're ready, that would be great. |
The context menu in the TinyMCE editor only displayed a "Link" option but as a result disabled the browser-native context menu which includes more useful actions. This change disables the context menu.
What changed?
Developer Checklist
Testing Instructions
Install the XBlock and see that the context menu in TinyMCE is disabled.
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora