Skip to content

Change python coveragerc file#13115

Merged
aphanse merged 1 commit into
masterfrom
aphanse/modify-coveragerc
Aug 1, 2016
Merged

Change python coveragerc file#13115
aphanse merged 1 commit into
masterfrom
aphanse/modify-coveragerc

Conversation

@aphanse

@aphanse aphanse commented Jul 27, 2016

Copy link
Copy Markdown
Contributor

@estute @jzoldak @benpatterson
Changing the python coveragerc file to work when using different versions of the unit coverage and test subset job. For context, this file gets called by the unit coverage job in order to create the reports for coverage.py. Thus, the $JOB_NAME is the unit coverage job. This is done to make sure python unit tests pr job works on the various repositories.

@jzoldak

jzoldak commented Jul 27, 2016

Copy link
Copy Markdown
Contributor

If a jenkins worker runs one job, then sticks around and runs another one, is it possible that this we will get inaccurate results? We don't clean up workspaces after jobs end.

Another concern - for workers that can run concurrent jobs, IIRC the workspace folder name will append a numerical identifier to distinguish. workspace, workspace@2, workspace@3. I'm not sure if we considered that in the original lines that you're changing now.

@aphanse

aphanse commented Jul 27, 2016

Copy link
Copy Markdown
Contributor Author

@jzoldak

  1. No, we shouldn't get inaccurate results. The environment variables which are added by the unit coverage job would have changed.
  2. The file is run by unit coverage which works on coverage worker which cannot do concurrent jobs as far as I know. The lines would likely not be able to handle having different workspace names, but since coverage worker doesn't support that anyway it should be fine.

@jzoldak

jzoldak commented Jul 29, 2016

Copy link
Copy Markdown
Contributor

Thanks for answering my ?s.
👍 for merging
please verify the coverage # after merging and make sure that it matches that calculated before the merge.

@estute

estute commented Jul 29, 2016

Copy link
Copy Markdown
Contributor

👍

@aphanse aphanse merged commit 8892051 into master Aug 1, 2016
@aphanse aphanse deleted the aphanse/modify-coveragerc branch August 2, 2016 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants