Skip to content

Conversation

@ChrisChV
Copy link
Contributor

Description

Supporting information

Testing instructions

  • Go to the library home of a library
  • Create this structure Unit > Subsection > Section.
  • Publish all the changes.
  • Update the Unit name. Verify that the Unit and the Subsection have the unpublished changes chip.
  • Publish the Unit. Verify that the unpublished changes chip is gone for the Unit and the Subsection.
  • Update the Subsection name. Verify that the Subsection and the Section have the unpublished changes chip.
  • Publish the Subsection. Verify that the unpublished changes chip is gone for the Subsection and the Section.

Deadline

None

Other information

N/A

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 11, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisChV Nice work! 👍

  • I tested this: (Verified that the bug is fixed)
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@ChrisChV ChrisChV enabled auto-merge (squash) November 12, 2025 18:38
@ChrisChV ChrisChV merged commit 4804c98 into openedx:master Nov 12, 2025
48 checks passed
@ChrisChV ChrisChV deleted the chris/FAL-4270-fix-unpublished-parent-container branch November 12, 2025 18:58
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Nov 12, 2025
ChrisChV added a commit to open-craft/edx-platform that referenced this pull request Nov 12, 2025
…nedx#37622)

Calls `LIBRARY_CONTAINER_PUBLISHED` when publishing a container that is child of another container.
ChrisChV added a commit that referenced this pull request Nov 13, 2025
) (#37629)

Calls `LIBRARY_CONTAINER_PUBLISHED` when publishing a container that is child of another container.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants