Skip to content

Conversation

@PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Dec 8, 2025

Description

Since we have the feature flag ENABLE_COURSE_SORTING_BY_START_DATE, which provides a boolean value, and we also receive the enable_course_sorting_by_start_date parameter (as a string) through the form-data in the /search/unstable/v0/course_list_search/ API, this PR introduces the normalize_bool function to ensure that the enable_course_sorting_by_start_date parameter is always a boolean before being used in conditional logic.

Before

The value of enable_course_sorting_by_start_date was always evaluated as True, because it was passed as a string ("true" / "false").

Now

Depending on the actual data type of enable_course_sorting_by_start_date, its value is normalized to a proper Python bool using the new normalize_bool function.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 8, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Dec 8, 2025

Thanks for the pull request, @PKulkoRaccoonGang!

This repository is currently maintained by @Ali-Salman29.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Dec 8, 2025
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/normalize-start-date-sort-param branch 4 times, most recently from b89d948 to a59d7ab Compare December 8, 2025 07:41
@PKulkoRaccoonGang PKulkoRaccoonGang self-assigned this Dec 8, 2025
return (self._end_time - self._start_time).seconds


def normalize_bool(value):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[inform]: Since distutils.util.strtobool is deprecated, a custom normalize_bool helper has been added.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/normalize-start-date-sort-param branch 7 times, most recently from f8ea35e to 42aca6a Compare December 8, 2025 13:08
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review December 8, 2025 13:11
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/normalize-start-date-sort-param branch from 42aca6a to 76cebd5 Compare December 8, 2025 13:12
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/normalize-start-date-sort-param branch from c447fa0 to dbbbf9e Compare December 8, 2025 13:30
Copy link
Member

@kyrylo-kh kyrylo-kh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feanil feanil requested a review from a team December 10, 2025 18:47
Copy link

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Too bad the API is using POST form values instead of JSON data.

@bradenmacdonald bradenmacdonald merged commit 4cccaad into openedx:master Dec 11, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants