[ENT-10287] - feat: add can_request action#702
Merged
Conversation
hamzawaleed01
force-pushed
the
ENT-10287/feat-can-request-method
branch
from
6a972b4 to
cdcca14
Compare
hamzawaleed01
commented
May 15, 2025
hamzawaleed01
force-pushed
the
ENT-10287/feat-can-request-method
branch
5 times, most recently
from
41377bf to
8e6e64d
Compare
hamzawaleed01
force-pushed
the
ENT-10287/feat-can-request-method
branch
from
8e6e64d to
4cb7f0b
Compare
hamzawaleed01
commented
May 20, 2025
hamzawaleed01
force-pushed
the
ENT-10287/feat-can-request-method
branch
from
4cb7f0b to
9a8b6e8
Compare
…10287/feat-can-request-method
hamzawaleed01
force-pushed
the
ENT-10287/feat-can-request-method
branch
4 times, most recently
from
a5f9b15 to
7b4c919
Compare
hamzawaleed01
force-pushed
the
ENT-10287/feat-can-request-method
branch
from
7b4c919 to
7275d98
Compare
sameenfatima78
approved these changes
May 22, 2025
Member
sameenfatima78
left a comment
sameenfatima78
left a comment
There was a problem hiding this comment.
Looks good, dropped one minor suggestion. Please also get a review from @zamanafzal and @ahmad-hassan-dev
hamzawaleed01
force-pushed
the
ENT-10287/feat-can-request-method
branch
2 times, most recently
from
b50b744 to
39b25c0
Compare
…10287/feat-can-request-method
hamzawaleed01
force-pushed
the
ENT-10287/feat-can-request-method
branch
from
39b25c0 to
f67a30a
Compare
…10287/feat-can-request-method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Introduced a new
can_requestendpoint for BnR(Browse and Request) feature.It checks if a learner can request access to content. The flow is:
1. Find BnR enabled policies first
2. Check if content key exists in those policies
3. Check for existing pending request by this learner
Jira:
ENT-10287
Merge checklist:
./manage.py makemigrationshas been runPost merge: