Skip to content

fix: add context in the create_thread#102

Merged
Ali-Salman29 merged 1 commit intomasterfrom
alisalman/fix-create-thread
Oct 14, 2024
Merged

fix: add context in the create_thread#102
Ali-Salman29 merged 1 commit intomasterfrom
alisalman/fix-create-thread

Conversation

@Ali-Salman29
Copy link
Copy Markdown
Contributor

Add context field in the create_thread

@regisb
Copy link
Copy Markdown
Contributor

regisb commented Oct 14, 2024

Why is this change needed?

@Ali-Salman29 Ali-Salman29 merged commit c32f18f into master Oct 14, 2024
@Faraz32123
Copy link
Copy Markdown
Contributor

Why is this change needed?

this Change was needed to support edx-platform tests as in tests different value for context was being used instead of only default(i.e. context). So, we needed this argument.

@regisb regisb deleted the alisalman/fix-create-thread branch October 15, 2024 06:48
@regisb
Copy link
Copy Markdown
Contributor

regisb commented Oct 15, 2024

OK. I was asking that to improve the git commit title message. In the git information, try to describe not what you are doing, but why you are doing it. The code shows the what. The git information should tell readers the reason for the change. In this particular case, a better git commit title would have been something along the lines of: "fix: edx-platform tests crash with 'FooBar' exception". And then, in the git commit message (always include a git commit message!!!) you explain how your change resolves the issue mentioned in the title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants