FC-0057: add params parameter to the requests#12
Merged
Faraz32123 merged 1 commit intomasterfrom Aug 1, 2024
Merged
Conversation
Faraz32123
force-pushed
the
fix/add_params_to_the_request_plus_some_improvements
branch
from
e0672b1 to
c267878
Compare
Ali-Salman29
approved these changes
Aug 1, 2024
- add missing params to the requests call - simplify all requests call into a single request helper
Faraz32123
force-pushed
the
fix/add_params_to_the_request_plus_some_improvements
branch
from
c267878 to
4ab7cc8
Compare
Faraz32123
deleted the
fix/add_params_to_the_request_plus_some_improvements
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge checklist:
Check off if complete or not applicable: