fix: requirements to make forum work with edx-platform#121
Merged
Faraz32123 merged 2 commits intomasterfrom Oct 25, 2024
Merged
Conversation
As updating the pylint version to latest fails edx CI and If pinning it to the same version as it(forum) has before, it fails compiling the requirements in edx-platofrm So, adding the same constraint for pylint as edx-platform has for it. i.e. `pylint<2.16.0`
Ali-Salman29
approved these changes
Oct 25, 2024
Contributor
Author
- added `too-many-positional-arguments` disable list in pylintrc to fix these warning:https://github.com/edly-io/forum/actions/runs/11513603527/job/32050616644
Faraz32123
changed the title
Faraz32123
deleted the
fix/pin_pylint_to_the_same_version_as_that_edx-platofrm
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As updating the pylint version to latest fails edx CI and If pinning it to the same version as it(forum) has before, it fails compiling the requirements in edx-platofrm So, adding the same constraint for pylint as edx-platform has for it. i.e.
pylint<2.16.0